Skip to content

Commit

Permalink
support setting bindplane prometheus image tag (#165)
Browse files Browse the repository at this point in the history
  • Loading branch information
jsirianni authored Sep 19, 2024
1 parent e55cdfd commit c028cca
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/bindplane/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: bindplane
description: BindPlane OP is an observability pipeline.
type: application
# The chart's version
version: 1.17.2
version: 1.17.3
# The BindPlane OP tagged release. If the user does not
# set the `image.tag` values option, this version is used.
appVersion: 1.73.0
Expand Down
3 changes: 2 additions & 1 deletion charts/bindplane/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# bindplane

![Version: 1.17.2](https://img.shields.io/badge/Version-1.17.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.73.0](https://img.shields.io/badge/AppVersion-1.73.0-informational?style=flat-square)
![Version: 1.17.3](https://img.shields.io/badge/Version-1.17.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.73.0](https://img.shields.io/badge/AppVersion-1.73.0-informational?style=flat-square)

BindPlane OP is an observability pipeline.

Expand Down Expand Up @@ -126,6 +126,7 @@ BindPlane OP is an observability pipeline.
| prometheus.extraPodLabels | object | `{}` | Optional arbitrary labels to add to the Prometheus pod. This option is only used when Prometheus is running as a StatefulSet managed by the chart (The default mode). |
| prometheus.host | string | `""` | The Prometheus hostname or IP address used for querying and writing metrics. Defaults to the service name of the Prometheus StatefulSet deployed by this chart. |
| prometheus.image.name | string | `"ghcr.io/observiq/bindplane-prometheus"` | Image name to be used. Defaults to `ghcr.io/observiq/bindplane-prometheus`. NOTE: The image tag is derived from the BindPlane server tag. |
| prometheus.image.tag | string | `""` | Image tag to use. Defaults to the bindplane version defined in the Chart's release. This option should be used when a specific bindplane-prometheus image is required, or if using upstream Prometheus. |
| prometheus.port | int | `9090` | The Prometheus TCP port used for querying and writing metrics. |
| prometheus.queryPathPrefix | string | `""` | Optional Prometheus query path prefix. Useful when overriding the query endpoints when using systems such as Mimir. |
| prometheus.remote | bool | `false` | When true, the chart will not deploy Prometheus. Instead, the user should provide a Prometheus instance to use. |
Expand Down
5 changes: 4 additions & 1 deletion charts/bindplane/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,14 @@ The image to use
{{- end -}}

{{/*
The image tag to use
The image tags to use
*/}}
{{- define "bindplane.tag" -}}
{{- printf "%s" (default (printf "%s" .Chart.AppVersion) .Values.image.tag) }}
{{- end -}}
{{- define "prometheus.tag" -}}
{{- printf "%s" (default (printf "%s" .Chart.AppVersion) .Values.prometheus.image.tag) }}
{{- end -}}

{{/*
The Transform Agent image to use
Expand Down
2 changes: 1 addition & 1 deletion charts/bindplane/templates/bindplane.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ spec:
{{- if eq (include "bindplane.deployment_type" .) "StatefulSet" }}
{{- if and (.Values.prometheus.enableSideCar) (eq .Values.prometheus.remote false)}}
- name: prometheus
image: {{ .Values.prometheus.image.name }}:{{ include "bindplane.tag" . }}
image: {{ .Values.prometheus.image.name }}:{{ include "prometheus.tag" . }}
imagePullPolicy: IfNotPresent
securityContext:
runAsNonRoot: true
Expand Down
2 changes: 1 addition & 1 deletion charts/bindplane/templates/prometheus.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
{{- end }}
containers:
- name: prometheus
image: {{ .Values.prometheus.image.name }}:{{ include "bindplane.tag" . }}
image: {{ .Values.prometheus.image.name }}:{{ include "prometheus.tag" . }}
imagePullPolicy: IfNotPresent
securityContext:
allowPrivilegeEscalation: false
Expand Down
2 changes: 2 additions & 0 deletions charts/bindplane/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ prometheus:
image:
# -- Image name to be used. Defaults to `ghcr.io/observiq/bindplane-prometheus`. NOTE: The image tag is derived from the BindPlane server tag.
name: "ghcr.io/observiq/bindplane-prometheus"
# -- Image tag to use. Defaults to the bindplane version defined in the Chart's release. This option should be used when a specific bindplane-prometheus image is required, or if using upstream Prometheus.
tag: ""
# -- When true, the chart will not deploy Prometheus. Instead, the user should provide a Prometheus instance to use.
remote: false
# -- When enabled, the Prometheus measurements backend will be deployed as a sidecar container. This option is only valid when BindPlane is running as a single node statefulset.
Expand Down

0 comments on commit c028cca

Please sign in to comment.