Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(istio): Rename nats client port to tcp to resolve istio protocol detection issue #137

Merged
merged 3 commits into from
Jul 15, 2024
Merged

fix(istio): Rename nats client port to tcp to resolve istio protocol detection issue #137

merged 3 commits into from
Jul 15, 2024

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Jul 15, 2024 •
edited
Loading

Description of Changes

Removes the word "client" from port 4222, to prevent istio from auto detecting the wrong protocol.

See

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes

@jsirianni jsirianni marked this pull request as ready for review July 15, 2024 13:49
@jsirianni jsirianni requested a review from a team as a code owner July 15, 2024 13:49
@jsirianni jsirianni requested review from shazlehu, kuiperda and tbm48813 and removed request for a team July 15, 2024 13:49
@jsirianni jsirianni merged commit 9c74c52 into main Jul 15, 2024
19 checks passed
@jsirianni jsirianni deleted the fix/istio branch July 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbm48813 tbm48813 tbm48813 approved these changes

@shazlehu shazlehu Awaiting requested review from shazlehu shazlehu was automatically assigned from observIQ/platform

@kuiperda kuiperda Awaiting requested review from kuiperda kuiperda was automatically assigned from observIQ/platform

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirianni @tbm48813