Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy remote url #141

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Remove legacy remote url #141

merged 1 commit into from
Aug 6, 2024

Conversation

jsirianni
Copy link
Member

Description of Changes

This option has not been used for some time, use server url.

config.server_url will configure BindPlane's BINDPLANE_CONFIG_REMOTE_URL option.

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes
  • Changes to ports, services, or other networking have been tested with istio

@jsirianni jsirianni marked this pull request as ready for review August 5, 2024 18:18
@jsirianni jsirianni requested a review from tbm48813 as a code owner August 5, 2024 18:18
@jsirianni jsirianni merged commit 3e0100b into main Aug 6, 2024
19 checks passed
@jsirianni jsirianni deleted the remove-remote-url branch August 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants