Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bbolt data directory permissions #151

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

algchoo
Copy link
Contributor

@algchoo algchoo commented Aug 23, 2024

Description of Changes

This PR updates the ownership and permissions for the bbolt data directory. It's configured to only add the necessary script (via a configMap) and initContainer if the backend is of type bbolt.

Based on the ticket, it's a little unclear to me whether or not these changes need to be applied to other deployments. The slack messages refer only to the bindplane container, I believe, so I started with that. It's also a bit unclear if we actually want to update the containerSecurityContext defaults.

Screenshot of the permissions when running locally on minikube with bbolt as backend:
Screenshot 2024-08-23 at 2 51 40 PM

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes
  • Changes to ports, services, or other networking have been tested with istio

Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algchoo please increment the Chartfile minor version and run helm-docs command to update the readme. https://github.com/norwoodj/helm-docs

charts/bindplane/templates/configmap.yaml Outdated Show resolved Hide resolved
@jsirianni jsirianni self-requested a review August 26, 2024 16:16
@algchoo algchoo marked this pull request as ready for review August 26, 2024 17:34
@algchoo algchoo requested a review from tbm48813 as a code owner August 26, 2024 17:34
@jsirianni jsirianni merged commit 733963b into main Aug 26, 2024
19 checks passed
@jsirianni jsirianni deleted the fix/data-dir-permissions branch August 26, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants