Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topologySpreadConstraints configuration option for deployments #157

Conversation

algchoo
Copy link
Contributor

@algchoo algchoo commented Sep 9, 2024

Description of Changes

This PR adds a topologySpreadConstraints configuration option to the values.yaml for the following deployments/resource:

  • bindplane
  • bindplane-nats
  • bindplane-jobs
  • prometheus
  • transform_agent

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes
  • Changes to ports, services, or other networking have been tested with istio

@algchoo algchoo marked this pull request as ready for review September 9, 2024 17:37
test/cases/all/values.yaml Outdated Show resolved Hide resolved
@algchoo algchoo force-pushed the austingeorgiades/bpop-634-bindplane-helm-support-topologyspreadconstraints branch from 7fe4d65 to 4287b98 Compare September 11, 2024 15:42
@algchoo algchoo requested a review from jsirianni September 11, 2024 15:43
@jsirianni jsirianni merged commit 56b991b into main Sep 11, 2024
19 checks passed
@jsirianni jsirianni deleted the austingeorgiades/bpop-634-bindplane-helm-support-topologyspreadconstraints branch September 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants