Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support pod terminationGracePeriodSeconds #182

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat: Support pod terminationGracePeriodSeconds #182

merged 2 commits into from
Dec 12, 2024

Conversation

jsirianni
Copy link
Member

@jsirianni jsirianni commented Nov 20, 2024 •
edited
Loading

Description of Changes

Similar to #181, adds support for configuring terminationGracePeriodSeconds for all deployments.

Testing

I deployed BindPlane HA w/ NATs.

After adding the following to my values and re-deploying

terminationGracePeriodSeconds:
  bindplane: 30
  nats: 31
  jobs: 32
  prometheus: 33
  transform_agent: 34

I see this

    terminationGracePeriodSeconds: 30
    terminationGracePeriodSeconds: 32
    terminationGracePeriodSeconds: 31
    terminationGracePeriodSeconds: 31
    terminationGracePeriodSeconds: 31
    terminationGracePeriodSeconds: 33
    terminationGracePeriodSeconds: 34

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CI passes
  • Changes to ports, services, or other networking have been tested with istio

Base automatically changed from joesirianni/bpop-1277-helm-allow-setting-priorityclassname-for-all-deployments to main November 20, 2024 20:55
@jsirianni jsirianni force-pushed the joesirianni/bpop-1278-helm-allow-setting-terminationgraceperiodsecondsfor-all branch from 3155a54 to 56e9844 Compare November 20, 2024 20:57
@jsirianni jsirianni marked this pull request as ready for review November 20, 2024 21:00
@jsirianni jsirianni requested a review from tbm48813 as a code owner November 20, 2024 21:00
@jsirianni
Copy link
Member Author

@tbm48813 for your review when you have a moment.

@jsirianni jsirianni force-pushed the joesirianni/bpop-1278-helm-allow-setting-terminationgraceperiodsecondsfor-all branch from 56e9844 to 968c352 Compare December 12, 2024 18:55
@jsirianni jsirianni force-pushed the joesirianni/bpop-1278-helm-allow-setting-terminationgraceperiodsecondsfor-all branch from 968c352 to 823a5fd Compare December 12, 2024 20:39
@jsirianni jsirianni merged commit 8650a93 into main Dec 12, 2024
22 checks passed
@jsirianni jsirianni deleted the joesirianni/bpop-1278-helm-allow-setting-terminationgraceperiodsecondsfor-all branch December 12, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbm48813 tbm48813 tbm48813 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirianni @tbm48813