feat: Boost default resources and support configuring healthcheck probes #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
On slower systems, bindplane can fail to deploy because it takes too long to startup. The default cpu / memory values are too low in general, and fall outside of our recommended sizing.
To combat this, I have boosted the default resources and exposed each healthcheck in the values file.
1000m
(one core)1000Mi
1000Mi
Testing
First, deploy the
main
branch in order to test upgrading to this branch.Create
values.yaml
file:Deploy with:
helm --values values.yaml template charts/bindplane | k apply -f -
Wait for the pods to startup.
kubectl get pod -n default
.Once stabilized, you can checkout this branch and re-run the
helm template
command. You should see the bindplane pod and the transform pod restarting, with new resource values.You can view the rendered yaml using helm template without piping to kubectl.
If you inspect the yaml output, you will see that the healthcheck probes have the correct configuration.
You can log into bindplane with:
Navigate to http://localhost:3011 and login with
bpuser
/bppass
.Please check that the PR fulfills these requirements