feat: Refactor to OCB based agent #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
force-pushed
the
feat/agent-2.0
branch
7 times, most recently
from
8cbab65 to
143afe7
Compare
BinaryFissionGames
suggested changes
Jul 25, 2024
Comment on lines
-90
to
-92
| - src: release_deps/config.yaml | ||
| dst: "." | ||
| strip_parent: true |
There was a problem hiding this comment.
Looks like you have to remove this from the nfpms section as well?
make release-test errors for me: nfpm failed for observiq-otel-collector_v1.56.0-SNAPSHOT-3edff07f_linux_ppc64.rpm: matching "./release_deps/config.yaml": file does not exist
There was a problem hiding this comment.
yea good call, I think I removed it in one of my later pr's but forgot to do so here
There was a problem hiding this comment.
Looks like this file is still referenced in the dockers section, which causes release-test to fail. Can we remove config.yaml form there too?
There was a problem hiding this comment.
Yea, blanked on that
dpaasman00
force-pushed
the
feat/agent-2.0
branch
from
26fe69a to
5436dbc
Compare
jsirianni
reviewed
Jul 30, 2024
BinaryFissionGames
suggested changes
Aug 1, 2024
Comment on lines
-90
to
-92
| - src: release_deps/config.yaml | ||
| dst: "." | ||
| strip_parent: true |
There was a problem hiding this comment.
Looks like this file is still referenced in the dockers section, which causes release-test to fail. Can we remove config.yaml form there too?
BinaryFissionGames
approved these changes
Aug 2, 2024
dpaasman00
added a commit
that referenced
this pull request
Aug 16, 2024
* wip * refactor repo * update workflow go versions * update build flow to install-tools * update build license check * new make target * rename to manifests * update release workflow * package supervisor with agent * resolve errs with gcp exporters * update version to have go.mod * get google exporters correctly importing version * manifest documentation * use updated version commit in google exporters * include supervisor as prebuilt binary * remove config.yaml from release pkg since its not used by supervisor/agent now * feedback 1/n * rebase cleanup * update go version in a few actions, use https git clone for contrib * change tool cache and fix release-test * replace rest of tool caches
dpaasman00
added a commit
that referenced
this pull request
Sep 11, 2024
* wip * refactor repo * update workflow go versions * update build flow to install-tools * update build license check * new make target * rename to manifests * update release workflow * package supervisor with agent * resolve errs with gcp exporters * update version to have go.mod * get google exporters correctly importing version * manifest documentation * use updated version commit in google exporters * include supervisor as prebuilt binary * remove config.yaml from release pkg since its not used by supervisor/agent now * feedback 1/n * rebase cleanup * update go version in a few actions, use https git clone for contrib * change tool cache and fix release-test * replace rest of tool caches
dpaasman00
added a commit
that referenced
this pull request
Oct 7, 2024
* wip * refactor repo * update workflow go versions * update build flow to install-tools * update build license check * new make target * rename to manifests * update release workflow * package supervisor with agent * resolve errs with gcp exporters * update version to have go.mod * get google exporters correctly importing version * manifest documentation * use updated version commit in google exporters * include supervisor as prebuilt binary * remove config.yaml from release pkg since its not used by supervisor/agent now * feedback 1/n * rebase cleanup * update go version in a few actions, use https git clone for contrib * change tool cache and fix release-test * replace rest of tool caches
dpaasman00
added a commit
that referenced
this pull request
Nov 14, 2024
* wip * refactor repo * update workflow go versions * update build flow to install-tools * update build license check * new make target * rename to manifests * update release workflow * package supervisor with agent * resolve errs with gcp exporters * update version to have go.mod * get google exporters correctly importing version * manifest documentation * use updated version commit in google exporters * include supervisor as prebuilt binary * remove config.yaml from release pkg since its not used by supervisor/agent now * feedback 1/n * rebase cleanup * update go version in a few actions, use https git clone for contrib * change tool cache and fix release-test * replace rest of tool caches
dpaasman00
added a commit
that referenced
this pull request
Dec 9, 2024
* wip * refactor repo * update workflow go versions * update build flow to install-tools * update build license check * new make target * rename to manifests * update release workflow * package supervisor with agent * resolve errs with gcp exporters * update version to have go.mod * get google exporters correctly importing version * manifest documentation * use updated version commit in google exporters * include supervisor as prebuilt binary * remove config.yaml from release pkg since its not used by supervisor/agent now * feedback 1/n * rebase cleanup * update go version in a few actions, use https git clone for contrib * change tool cache and fix release-test * replace rest of tool caches
dpaasman00
added a commit
that referenced
this pull request
Dec 16, 2024
* wip * refactor repo * update workflow go versions * update build flow to install-tools * update build license check * new make target * rename to manifests * update release workflow * package supervisor with agent * resolve errs with gcp exporters * update version to have go.mod * get google exporters correctly importing version * manifest documentation * use updated version commit in google exporters * include supervisor as prebuilt binary * remove config.yaml from release pkg since its not used by supervisor/agent now * feedback 1/n * rebase cleanup * update go version in a few actions, use https git clone for contrib * change tool cache and fix release-test * replace rest of tool caches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Initial refactoring of repo to be based on the OCB and Supervisor. This project now consists of a collection of components (exporters, extensions, plugins, processors, and receivers), OCB manifests, and release tooling. Deleted folders and files that are no longer necessary. The OCB and Supervisor are installed as tools after running
make install-tools.With several changes, here's how the different aspects can be tested/verified.
make release-testto verify updated release process works.distfolder to verify contents. New contents include the opamp supervisor and a supervisor config. Can experiment with running them if you'd like.make install-toolsand thenmake agent. Copy the example supervisor config inconfiginto yourlocalfolder assupervisor-config.yaml. Update the authorization header and endpoint params as needed, and complete the name of the agent executable with your GOOS and GOARCH so it matches the bin indist. Now you should be able to runmake run-supervisorand see your agent connect to bindplane. Callmake killin another terminal to fully stop the supervisor.Next Steps
The next steps to take are updating the install scripts so they are able to start the agent with the supervisor on start up. The Updater for the agent also needs to be revisited and updated accordingly.
Checklist