chore: Disable confmap featuregate #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
force-pushed
the
dakotapaasman/bpop-390-address-confmapstrictlytypedinput-feature-gate
branch
from
bf4cd53 to
31ebbaf
Compare
BinaryFissionGames
approved these changes
Aug 28, 2024
jsirianni
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
We have been running into issues with old versions of bindplane supporting the latest agent. This was expected, but did cause an uptick in support cases.
This change sounds safe. Just noting that we should be sure that any changes to the agent have been sorted out in recent versions of BindPlane.
dpaasman00
deleted the
dakotapaasman/bpop-390-address-confmapstrictlytypedinput-feature-gate
branch
BinaryFissionGames
pushed a commit
that referenced
this pull request
Sep 3, 2024
disable confmap featuregate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Disable the
confmap.strictlyTypedInputfeaturegate (needs to be done before v0.110.0 of OTel).Ran into issues while updating OTel a few releases ago but no issues disabling now. I think there was some overlap with the environment var expansion feature gate stuff that was causing this one to fail too (issue here goes into more detail). Now that the env var stuff is taken care disabling this featuregate seems fine.
Checklist