feat: SSAPI Auth Token (BPS-281) #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are because I copied over a test file from the other PR to add to it. The failure should be resolved once the unit test PR gets merged. |
schmikei
reviewed
Dec 2, 2024
| @@ -51,12 +58,27 @@ func (cfg *Config) Validate() error { | |||
| if cfg.Endpoint == "" { | |||
| return errors.New("missing Splunk server endpoint") | |||
| } | |||
| if cfg.Username == "" { | |||
|
|
|||
| if cfg.Username == "" && cfg.AuthToken == "" { | |||
| return errors.New("missing Splunk username") | |||
There was a problem hiding this comment.
should we update this error string?
Suggested change
| return errors.New("missing Splunk username") | |
| return errors.New("missing Splunk username or auth token") |
| return errors.New("missing Splunk username") | ||
| } | ||
| if cfg.Password == "" { | ||
|
|
||
| if cfg.Password == "" && cfg.AuthToken == "" { | ||
| return errors.New("missing Splunk password") |
There was a problem hiding this comment.
Suggested change
| return errors.New("missing Splunk password") | |
| return errors.New("missing Splunk password or auth token") |
| @@ -111,22 +111,32 @@ func (ssapir *splunksearchapireceiver) Shutdown(ctx context.Context) error { | |||
|
|
|||
| func (ssapir *splunksearchapireceiver) runQueries(ctx context.Context) error { | |||
| for _, search := range ssapir.config.Searches { | |||
| // set default event batch size | |||
| fmt.Println(search.EventBatchSize) | |||
There was a problem hiding this comment.
Suggested change
| fmt.Println(search.EventBatchSize) |
| fmt.Println(search.EventBatchSize) | ||
| if search.EventBatchSize == 0 { | ||
| search.EventBatchSize = 100 | ||
| fmt.Println(search.EventBatchSize) |
There was a problem hiding this comment.
Suggested change
| fmt.Println(search.EventBatchSize) |
schmikei
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Adds auth tokens as an authentication option in addition to basic auth.
Checklist