chore: Rename to bindplane-agent #2025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
requested review from
justinianvoss22
and removed request for
justinianvoss22
dpaasman00
force-pushed
the
chore/clean-break
branch
from
8bc7478 to
0945224
Compare
jsirianni
requested changes
Dec 5, 2024
There was a problem hiding this comment.
- Container images fail with:
could not stat agent::executable path: stat /collector/observiq-otel-collector: no such file or directory
Probably need to update the binary path in the Dockerfiles.
- Linux packages fail with conflict error.
Error: Transaction test error:
file /opt/opentelemetry-java-contrib-jmx-metrics.jar from install of bindplane-agent-1.66.0SNAPSHOT_09452249-1.x86_64 conflicts with file from package observiq-otel-collector-2.0.0alpha.5-1.x86_64
We probably want to remove the conflict from Goreleaser's nfpm config so we can allow users to deploy v2 side by side v1.
* wip * refactor repo * update workflow go versions * update build flow to install-tools * update build license check * new make target * rename to manifests * update release workflow * package supervisor with agent * resolve errs with gcp exporters * update version to have go.mod * get google exporters correctly importing version * manifest documentation * use updated version commit in google exporters * include supervisor as prebuilt binary * remove config.yaml from release pkg since its not used by supervisor/agent now * feedback 1/n * rebase cleanup * update go version in a few actions, use https git clone for contrib * change tool cache and fix release-test * replace rest of tool caches
add a bit more detail on using a custom manifest
* wip * update macos install script * agent log file msg * agent labels * minor fixes, different storage name, agent log & cfg in supervisor storage * use shell formatter, remove supervisor ownership, rm rf agent repo for simplicity
* update unix install scripts * dedup messages * docker updates * docker working * rename to supervisor.yaml, add pre & post remove scripts, remove uninstall section, update entrypoint for docker images * update permission for supervisor cfg * new supervisor storage changes * use INSTALL_DIR const * messing around with pre-post scripts * use shell formatter & finalize scripts * remove returns, update msg, remove log dir creation in goreleaser * move supervisors files creation into goreleaser * only pull most recent contrib commit, change replace to internal pkg for gcp exporters * chown opampsupervisor * remove user var
* shell formatter * wip * working script * polish script, add cleanup option * add license to new script * add yq install comment * typo
* wip * initial testing * add goreleaser logging * install tools * simplify manual msi build action * fix supervisor binary * polish * change back service name * remove goreleaser logs * update supervisor labels field * add supervisor_storage, rename cfg to supervisor.yaml, try removing supervisor storage on uninstall * cleanup logging and use -r flag when removing supervisor_storage * include supervisor_storage dir
* remove logging.yaml * remove logging files
* unix script clean install * macos script clean install * add force clean install option * add force dirty install (update) option
* polish v2 release * rearrange comment * ci * reduce build size * ci
update go-msi dep
* comment out docker images in goreleaser * fix license scan
fix build for supervisor in 2.0
* re-add some containers for alpha v2 releases * remove extra space in image tag
mark httpprovider v1.17.0
* fix bad manifests * revert name change
* wip 1 * wip 2 * rework agent docs to be supervisor/v2 oriented * remove 'starts' typo Co-authored-by: Brandon Johnson <[email protected]> * ci --------- Co-authored-by: Brandon Johnson <[email protected]>
update install scripts with supervisor logging
…1920) preserve supervisor_storage dir on uninstall
* use default opamp endpoint on mac & linux; testing for windows * msi creates supervisor.yaml even if enablemanagement not true * fix port in default opamp endpoint * include default supervisor cfg in release pkgs, check for known cfg file hash * fix shellchecks
* Disable CGO for supervisor and agent builds * Consolidate CGO_ENABLED=0 flag
* Set CURR_VERSION for new v2 release-prep calls * Adjust where v is placed * Update manual_msi_build to use correct curr_version
dpaasman00
force-pushed
the
release/v2.0.0
branch
from
958f346 to
acd3648
Compare
dpaasman00
force-pushed
the
chore/clean-break
branch
from
0945224 to
864f357
Compare
dpaasman00
force-pushed
the
release/v2.0.0
branch
from
acd3648 to
1293dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
bindplane-agentaffecting the package name, image name, binary name, docs, etc.Checklist