chore: Add new tests for chronicle exporter with http and grpc servers #2049
+490
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
split-http-grpc-4
branch
from
d286ea1 to
0faa256
Compare
mrsillydog
reviewed
Dec 16, 2024
|
Looks like it was an unrelated flaky test. Passed on a second run though. |
mrsillydog
approved these changes
Dec 16, 2024
dpaasman00
pushed a commit
that referenced
this pull request
Dec 16, 2024
djaglowski
added a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #2048, another step towards #2044
This PR mostly just adds tests, but a few minor changes are made to allow specific aspects of the code to be swapped out in those tests.
Regardless of protocol, a fake
tokenSourcefunction can be replaced, allowing us to bypass the loading of google credentials. Likewise, the endpoint is changed to point to the mock server. When using grpc, the dial opts are also changed to indicate no authentication. However, even with these changes the clients are real and actually exercised by the tests.When using http, the exporter correctly returns a permanent error on at least some error codes. More should be done here, but it is a start and can be validated by tests.
Finally, in writing these tests, I found a few error messages which should be simplified.
Overall, test coverage for the exporter is improved from about to 61% to 72%.