[cmd/opampsupervisor] Specify PID to monitor for collector orphan detection #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
from
9c7ac76 to
42b03db
Compare
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
3 times, most recently
from
20978e6 to
51ec112
Compare
The testbed starts and stops the exporter once per signal, but we know it's the same exporter underneath. This PR changes the behavior of testbed to start and stop the exporter just once. This change is needed to support open-telemetry/opentelemetry-collector#10059 --------- Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Yang Song <[email protected]>
…been orphaned (open-telemetry#32564) **Description:** <Describe what has changed.> * Allows the process to monitor a passed in ppid, which should be the parent process ID for the collector. When the parent process ID exits, the extension emits a fatal error event, which triggers a collector shutdown. **Link to tracking Issue:** This is part of open-telemetry#32189 - It does not resolve this issue because the supervisor still needs changes to pass the its PID in. **Testing:** Added some unit tests. I've manually tested it on my macbook with this PR: #4715 (running supervisor, kill -9 the supervisor, and take a look at the agent logs to see it shut down). I've tried testing this out on Windows, but the supervisor doesn't get past bootstrapping (the Commander's Stop function does not work on windows), so I wasn't able to fully test it. **Documentation:** Added new parameter to README
…ion scope information (open-telemetry#32852) **Description:** Add additional methods to ignore scope span instrumentation scope information: * Version `IgnoreScopeSpanInstrumentationScopeVersion` * Name `IgnoreScopeSpanInstrumentationScopeName` * Attributes `IgnoreScopeSpanInstrumentationScopeAttributeValue` **Testing:** Added to tests.
Signed-off-by: Bogdan Drutu <[email protected]>
**Description:** Add a new feature in splunk hec exporter - utilitize batching framework open-telemetry/opentelemetry-collector#9738 in splunk hec exporter - adds batcher config in splunk hec exporter config and append it as exporter option if enabled **Link to tracking Issue:** Resolves open-telemetry#32545 **Testing:** Added unit test for the config **Documentation:** Updated the README file
…alizeProcessCPUUtilization` (open-telemetry#32502) **Description:** Switches the `receiver.hostmetrics.normalizeProcessCPUUtilization` feature gate to Beta, making it enabled by default. This is according to schedule described in the [docs](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.98.0/receiver/hostmetricsreceiver/README.md#feature-gates). **Link to tracking Issue:** - open-telemetry#31368 Co-authored-by: Pablo Baeyens <[email protected]>
…er (open-telemetry#32327) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds support for the logs agent exporter in order to export logs to Datadog. The following changes were made in order to support this: - Update datadog-agent modules to the following commit hash version: DataDog/datadog-agent@a1ef7ed - Remove `peer_service_aggregation` config option which was deprecated and removed since last datadog-agent version: DataDog/datadog-agent#23284 - Add logs agent exporter setup in datadog exporter factory. This is disabled by default and can be enabled via feature gate. **Link to tracking Issue:** Fixes open-telemetry#30099 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <[email protected]>
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Update opentelemetry-mapping-go to v0.16.0 **Link to tracking Issue:** Fixes DataDog/opentelemetry-mapping-go/issues/306
) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | docker.io/library/nginx | final | minor | `1.25` -> `1.26` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Boten <[email protected]>
](https://renovatebot.com){kind=link}
…etry#32864) Bump go-docappender to v2. No functional change. Alternative to open-telemetry#32640. Closes open-telemetry#32640.
…ind (open-telemetry#32836) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add config option for computing top level spans by span kind in the Datadog connector and exporter. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#32005 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Signed-off-by: Bogdan Drutu <[email protected]>
BinaryFissionGames
force-pushed
the
feat/opamp-supervisor-specify-ppid
branch
from
a86bb14 to
c667871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation:
Passes PID into the collector to activate orphan detection