Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use actions-rust-lang/setup-rust-toolchain #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Apr 17, 2024

Description

CI: Use actions-rust-lang/setup-rust-toolchain

Replace actions-rs/toolchain with actions-rust-lang/setup-rust-toolchain since the former is deprecated/archived and is throwing CI warnings.

Motivation and Context

Want less CI warnings.

Key points:

  1. actions-rust-lang/setup-rust-toolchain no longer exposes profile or override as options. If you want to set profile to minimal, you must provide a rust toolchain file.
  2. actions-rust-lang/setup-rust-toolchain seems to include Swatinum/rust-cache and will use it if you specify cache to the action. This can probably be addressed later, if desired.
    https://github.com/actions-rust-lang/setup-rust-toolchain/blob/b113a30d27a8e59c969077c0a0168cc13dab5ffc/action.yml#L174-L178

The initial run took longer than usual runs here, but that seems to have been due to the lack of cache. A subsequent run was comparable to run times here.
https://github.com/RytoEX/bouf/actions/runs/8726305940

How Has This Been Tested?

Tested on my fork.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Replace actions-rs/toolchain with actions-rust-lang/setup-rust-toolchain
since the former is deprecated/archived and is throwing CI warnings.
@RytoEX RytoEX requested a review from derrod June 6, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant