Clean up Windows Start Menu entry

[RedBlackAka]

Description

Simplifies the Start Menu entries created by the Windows installer to just one entry, in order to make it appear cleaner and modern.

Motivation and Context

Why have a Start Menu folder when it is just one entry (plus the uninstaller shortcut, but it is hidden since W10, so removal is appropriate and it is practically only one entry).

How Has This Been Tested?

Viewed on W10.

Types of changes

• Tweak (non-breaking change to improve existing functionality)

• Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[Fenrirthviti]

The uninstaller shortcut is not hidden, it shows up on my end on Windows 11 at least. This may be an environment setting specific to you.

I don't know that I agree with these changes, as many applications still provide the uninstall shortcut, and I don't know that this is actually making things easier for users in any meaningful capacity.

[RedBlackAka]

The uninstaller shortcut is not hidden, it shows up on my end on Windows 11 at least. This may be an environment setting specific to you.

I don't know that I agree with these changes, as many applications still provide the uninstall shortcut, and I don't know that this is actually making things easier for users in any meaningful capacity.

My bad. But why have a own shortcut for the unistaller, when you already have right click > Uninstall on the main entry? I deem it an outdated (basically obsolete) and visually unclean practice. You would not find this on most new applications either.

[Fenrirthviti]

Also for posterity, even Microsoft still puts single-shortcut applications in their own folder:

Additionally, I don't see an uninstall option when I right click on a menu item in the start menu for OBS Studio, which is probably handled by some environment setting somewhere that's poorly documented.

I understand that this might seem "cleaner" and may be recommended, but changing it at this stage doesn't seem worthwhile, IMO, especially with no cleanup of the old shortcuts as part of the consideration.

Raymond seems to agree that it's better as well, for what it's worth: https://devblogs.microsoft.com/oldnewthing/20190319-00/?p=102342

[RedBlackAka]

Also for posterity, even Microsoft still puts single-shortcut applications in their own folder:

Additionally, I don't see an uninstall option when I right click on a menu item in the start menu for OBS Studio, which is probably handled by some environment setting somewhere that's poorly documented.

I understand that this might seem "cleaner" and may be recommended, but changing it at this stage doesn't seem worthwhile, IMO, especially with no cleanup of the old shortcuts as part of the consideration.

Raymond seems to agree that it's better as well, for what it's worth: https://devblogs.microsoft.com/oldnewthing/20190319-00/?p=102342

Ahh I see. He does seem to both agree and disagree. The right click > Uninstall may actually require a NSIS entry that is currently not present. Could check things and find a way to make sure the old entries are also getting cleaned up when running both installer/uninstaller. I would really like this change and could handle the rest. And if you really do not want it, understandable, you can close this PR.

[RedBlackAka]

Alright the installer removes the old shortcuts now, so the change does no longer leave behind files when updating. Smooth transition. Also re-added them to the uninstaller, just in case. Plus the Uninstall thing not appearing is a W11 thing (they want you to explicitly use the Settings there). This could be considered done, thanks!

[RedBlackAka]

Status? I have given my arguments and put in the work, so a response would be appreciated

[Fenrirthviti]

PRs are reviewed as the project has the time and resource to so. We have no response at the moment as we are focused on our current beta cycle.