-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Remove i3 trigger #104
base: master
Are you sure you want to change the base?
Conversation
modern i3 models are no longer considered underpowered.
While the analyzer as run via OBS Bot does have Hardware Check, the analyzer itself does not. In practice, I'm sure that the analyzer gets more use via OBS Bot than the website (https://obsproject.com/tools/analyzer), but this does remove a possible flag from that usage. Perhaps it would make more sense to further restrict this INFO item with number of cores or generation? Or perhaps the message just needs changed to something like "Below minimum system requirements" (see below)? That said, apparently, we decided that our minimum system requirements for CPU is "Intel i5 2500K, AMD Ryzen 1300X" per the OBS Studio Steam page, so the current INFO message is technically correct in that i3 CPUs are below our minimum system requirements. If we want to change our minimum system requirements, we should probably be consistent. Food for thought, 10th gen laptop/mobile i3 CPUs seem to compare unfavorably, while desktop 10th gen i3 CPUs can compare okay. Laptop 10th gen i5 CPUs fare better, naturally.
|
Yeah, I understand. There are pros and cons. Feel free to close if it is unwanted. I think trying to filter the different gens Intel generations will prove quite tricky, as their naming setup vary quite a lot. An 8th gen laptop i3 (lets say 8121U, quite modest) beats out a 2500k syntethic compute, so I don't really agree with that sentiment that it does not meet min requirements. The class/series matter as well as mobile, but not I think its moot as long as you can beat the min required model. Maybe I don't quite understand what is meant by "unfavorably". Yes, mobile i3 is worse than desktop i3, but depending on the model, it is either on par, or comfortably overpower the 2500k. The ultra lower power (Y series) is of course a different matter entirely, but a 7th gen i5 Y series (i5-7Y54) is close to half perf of the 2500k, so again, I don't personally think thats valid basis either. Drawing a line in the sand is fine, and this probably a reasonable place to draw it without writing in support for checking actual benchmarks. |
Historically, I don't believe we've relied purely on synthetic compute benchmark scores. Perhaps some combination of benchmark, and number of physical/logical processors and threads? @derrod might remember. My point above was that, for example, the 10th gen i3-10110U scores worse than the i5-3570K, i7-2600K, or i5-2500K. That's a very recent i3, even if it is a laptop. Incidentally, the i3-1110G4 also scores worse, and that's an 11th gen. Another curious point, if you check for i3 CPUs with a CPU Mark score at or above the i5-2500K (4111+) on https://www.cpubenchmark.net you get 61 entries, whereas there are 119 entries below that score. If you remove all the U, Y, and E variants (including UE and UM) from both result sets, you still get 72 entries below 4111 CPU Mark and 48 entries at or above. Granted, that does not tell us anything about prevalence in the wild, but it does not inspire me with confidence. So I can see that the situation is certainly improving, but I'm still not 100% sure about this. That said, I don't particularly feel strongly against it, I'm just not strongly for it. Perhaps @Fenrirthviti has a strong opinion here. |
You make a strong case, and I am feeling more more inclined to agree. Maybe it is too early to remove the flag. Its not that common for people to be upset that their golden i3 is labeled "underpowered", and it might do more harm than good to remove it. Maybe revisit in two more gens. I am happy to close it. |
Just change this to information and adjust the wording, IMO.
The recommendation for using QSV or other hardware encoders, even on a "current" gen i3 is still relevant here, so the advice is correct, we can just soften the wording. |
Description
Removes the i3 trigger.
Motivation and Context
Modern i3 models are no longer considered underpowered.
Comparison to a 2nd gen ryzen 5: https://www.cpubenchmark.net/compare/Intel-Core-i3-12100F-vs-AMD-Ryzen-5-2600X/4670vs3235
How Has This Been Tested?
Ran simplehttp. Tested my own log as well as https://obsproject.com/logs/HIMr4cfWGGHTj5_2
Types of changes
Checklist: