network: Check max recommended bitrate from service #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgmitchell
force-pushed
the
checkServiceRecs
branch
from
ed46f03 to
75740d9
Compare
This adds a warning if the maximum recommended video bitrate from the selected service has been exceeded.
prgmitchell
force-pushed
the
checkServiceRecs
branch
from
3202bfa to
5594051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a warning if the maximum recommended video bitrate from the selected service has been exceeded.
Requires obsproject/obs-studio#10917 to be merged first.
Motivation and Context
Added logging to OBS to display max bitrate when the user elects to ignore the service recommendations, this brings that to the analyzer as well.
How Has This Been Tested?
Tested with this log https://obsproject.com/logs/ZuadI85OgoP0Yjjj
Types of changes
Checklist: