obs-browser: flush panel cookie store on exit #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cookie store is not flushed, state might become inconsistent: reading from the cookies file will become impossible. No errors will be returned, yet no information will be available, and no information will be stored: the cookie manager will appear to be empty at all times and the `Cookies` file modified date will not update moving forward. This will result, for example, in Twitch chat window re-opening for users which connected their Twitch account, but not having the `auth-token` cookie available: once the user will try to send a message to the chat, they will be redirected to Twitch login screen.
zavitax
force-pushed
the
flush_cookies_on_exit
branch
from
8b7a4c8 to
4c54fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cookie store is not flushed, state might become inconsistent:
reading from the cookies file will become impossible.
No errors will be returned, yet no information will be available,
and no information will be stored: the cookie manager will appear to be
empty at all times and the
Cookiesfile modified date will not updatemoving forward.
This will result, for example, in Twitch chat window re-opening for
users which connected their Twitch account, but not having the
auth-tokencookie available: once the user will try to send amessage to the chat, they will be redirected to Twitch login screen.