Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-browser: Ensure saved source is alive #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

walker-WSH
Copy link

@walker-WSH walker-WSH commented May 30, 2022

Description

In browser-client, created source is saved into two lists:

std::vector<obs_source_t*> audio_sources;
std::unordered_map<int, AudioStream> audio_streams;

But there is no reference for audio_sources.
I meet a crash as below:

1653896576

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@walker-WSH walker-WSH changed the title obs-browser: Unsure saved source is alive obs-browser: Ensure saved source is alive May 30, 2022
@walker-WSH walker-WSH force-pushed the wsh_KeepSourceAlive branch from c90b8c9 to 8578edc Compare May 30, 2022 07:45
@gxalpha
Copy link
Member

gxalpha commented May 30, 2022

Is there any particular reason why you're still running a CEF older than 4103?
I'm asking since we're looking to update our CEF again for the next version of OBS, in which case this code would get removed (we're usually supporting the current plus the last CEF).

@walker-WSH
Copy link
Author

walker-WSH commented May 30, 2022

Is there any particular reason why you're still running a CEF older than 4103? I'm asking since we're looking to update our CEF again for the next version of OBS, in which case this code would get removed (we're usually supporting the current plus the last CEF).

since the crash in #360 , I am still using the old CEF.

that crash of obs-browser-page.exe can be reproduced easy on my PC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants