Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Feature/multiview vu meter #10724

Closed

Conversation

mate1213
Copy link

@mate1213 mate1213 commented May 24, 2024

Description

Design on the multiview:
image
Settings:
image

Motivation and Context

In multiview I want to see the audio output.
FR

How Has This Been Tested?

Manually.
Scenarios:

  • Try out different resolutions, on different machines, with different preview size settings.
  • Enable/Disable audiometer display while the multiview open.
  • Change selected track while multiview open.
  • If there are no audio playing, show the default scale with levels -Inf.
  • If track has no data, fall back to stereo.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@gxalpha gxalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the PR template, explaining your changes and motivation. Make sure to include screenshots.

Additionally, please clean up the commit history by squashing commits together if you can (although that not as important right now, I recognize this is still marked as draft).

@gxalpha gxalpha added New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements. labels May 24, 2024
@mate1213
Copy link
Author

Hi,
This meant to be a draft only :D Yes I will fill everything out. Thanks to noticed.
It's just to see what do I have to change :D
Do I have to ping you, when it's done?
Br, Máté

@derrod
Copy link
Member

derrod commented May 25, 2024

Some screenshots would be nice.

@mate1213
Copy link
Author

Some screenshots would be nice.

I've put some in the description, as requested.

@mate1213
Copy link
Author

mate1213 commented May 26, 2024

Please fill out the PR template, explaining your changes and motivation. Make sure to include screenshots.

Additionally, please clean up the commit history by squashing commits together if you can (although that not as important right now, I recognize this is still marked as draft).

Except the squash commits, I think filled out everything.
I still need to do some fine tuning. I needed to add new files, but I'm not sure what additional steps do I have to do to work correctly in the repo. (Regarding the .sln generation, and CMAKE files)
Because locally I can run as intended. But this read the files from build_x64 directory as far as I know.

@mate1213 mate1213 force-pushed the feature/multiview-VU-meter branch from 38a306e to be7800e Compare May 29, 2024 18:17
@mate1213 mate1213 force-pushed the feature/multiview-VU-meter branch from 8974be1 to 0e45306 Compare May 29, 2024 18:46
@mate1213 mate1213 marked this pull request as ready for review May 29, 2024 18:54
@mate1213 mate1213 requested a review from gxalpha May 29, 2024 19:02
@mate1213 mate1213 changed the title Feature/multiview vu meter UI: Feature/multiview vu meter May 31, 2024
@Warchamp7
Copy link
Member

Warchamp7 commented Jun 3, 2024

There is currently an open RFC for making more significant changes to the OBS multiview. I consider this feature a significant enough of an addition to be part of that process.

As such I am going to close this PR for now, please feel free to add any other feedback to the RFC discussion in the meantime.

@Warchamp7 Warchamp7 closed this Jun 3, 2024
@mate1213
Copy link
Author

mate1213 commented Jun 3, 2024

@Warchamp7 Okay, I've already mentioned this there. And made these changes in mind that could be easily port into that. :D
Can I mention this PR there, like a possible implementation?
Edit: Just noticed because of the RFC mentioning it's already there :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants