Crashing VSTs

[c3r1c3]

Here I'll put the list of crashing VSTs and hopefully any fixes.

Entered so I don't forget tomorrow.

[c3r1c3]

(With the supplied headers... I will test with the Steinburg headers afterwards)

Line 25 errors happen when I'm trying to open the interface.
Line 185 and 71 errors happens when I replace/add the plugin.
Line 1279 errors happen when I try to remove/replace the plugin.

Error obs-vst.cpp, line 25, VstRect* vstRect = 0;
UAD Ampeg SVT3Pro
UAD Ampeg SVTVR
UAD Chandler GAV19T
UAD Friendman BE100
UAD Friendman DS40

Error: obs-vst.cpp; line 185, effect->dispatcher(effect, effSetChunk, 0, chunkData.length(), buf, 0);
UAD Ampex AMS RMX16 ()
UAD All Oxford Plugins (also gives a msvcr90.dll error)
SFX Machine Pro - 64-bit (also gives a SFX Machine Pro.64.dll error as well)

Error obs-vst.cpp, line 1279, return program.exec();
UAD bx_digital V3 mix

Error VSTPlugin.cpp, line 71, for (size_t c = 0; c < 8; c++) {
NI Battery 4 (also has a msvcr120.dll error as well)
NI Kontakt (16 out) (also has a vcruntime140.dll error as well)
NI Kontakt (also has a vcruntime140.dll error as well)
Note: Interesting that the Kontakt 8 out works just fine.
NI Reaktor5 (16 out) (also has a Reaktor5.dll error as well)
NI Reaktor5 FX(16x16) (also has a Reaktor5.dll error as well)
NI Reaktor5 FX Surround (also has a Reaktor5.dll error as well)

No Error per se, but interface doesn't load up:
Spectrasonics Keyscape & Omnisphere
AMT Amp Leveling
AMT Max Warm
AMT Multi-Max
BlueVerb DRV2080
British NEQ-1972
British MCL-2269
Any Liquid plugin, any BT or E-series plugins either...

I didn't note which plugins had this issue, but some of them didn't seem to update their interface correctly. I'll make another pass some day and put that in a separate posting.

[c3r1c3]

Okay, doing a clean build with the Steinburg headers I get the following with the above listed problem plugins:

Line 25 errors still happen. (Makes sense, the plugin is most likely wanted a stop-gap resolution to fit itself in).
Line 185 errors go away and the plugins load without issue. (Makes sense, given that this looks like a code behind/header issue).
Line 71 errors still happen. (Makes sense. OBS-vst isn't built to handle 16 tracks (or 8x Stereo pairs) of audio on a source).

Interface not opening error still happens. (Not sure on that one).

[c3r1c3]

As of PR #17 the issues with Line 25, Line 185 and Line 1279 are fixed with the bundled header.
Haven't done any tests with the Steinburg header yet.
The "No-show" plugins still don't show.
The Line 71 plugins still crash (but at a different place now).

[c3r1c3]

(Due to code changes the Line 71 error is now Line 88/89).

[c3r1c3]

With the latest patch, we can now open the interface for all the plug-ins that I have, that we couldn't before (sans those that crash at loading). This also means we are getting a new type of error for some of said plug-ins:

Tested with the bundled VST Header, we get a crash in the MS VS2014\VC\include\vector file, line 1235; MS VS2015 stops at the _SCL_SECURE_OUT_OF_RANGE code:

BlueVerb DRV2080
The various Liquid, BT and E Plugins that I have.
(Note: The BC &NEQ line of plug-ins work without issue though).

Additionally:
OmniSphere and Keyscape try to load/show-up, but crash at the Line (was 71, now) 88/89 place.

PLEASE NOTE: I was only able to apply this code fix to the Linux and Windows versions. Please port to OSX, if need be.

[SuslikV]

My own experience (different plugins, no matter what kind). Crashes related to Open UI, on very slow PC happens more frequently. More over, if I disable plugin (the "eye" icon left to the filter's name in OBS Filters) and then open UI of the loaded VST plugin (empty one of course, no processing) and then enable OBS Filter by clicking "eye" icon again - the crash almost never happens.

[sisalik1]

Pitchproof crash still exists: obsproject/obs-studio#2638