This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Fixes, clean up, and an attempt at Linux support. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w plugins proper to each platform. Also added Linux VST_PATH support. Also (I think) added more potential Linux paths.
See Github Issue obsproject#11 about plugins where OBS doesn't show an interface. Fixed.
See Github Issue obsproject#11 about plugins where OBS doesn't show an interface. Fixed. Also added some pathing code... but have no idea if it works. Sorry.
DDRBoxman
suggested changes
Jan 27, 2017
| wchar_t *wpath; | ||
| os_utf8_to_wcs_ptr(pluginPath.c_str(), 0, &wpath); | ||
| soHandle = LoadLibraryW(wpath); | ||
| // Why is this a (non-portable) wide char? |
There was a problem hiding this comment.
That's copied from the windows code. Windows needs a wchar because the filesystem APIs for unicode accept a wchar. On linux and osx you should just be able to pass the string to the os_dlopen. So you can remove all this extra stuff here.
There was a problem hiding this comment.
Thanks for merging. Am working on it now. Will have a new PR for you soon-ish.
There was a problem hiding this comment.
Also my next PR will include formatting fixes (if you haven't already done it) for everything.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes, enhancements, clean-up and an attempt at getting the Linux version working.
See github issue #11 for some more notes about that issue.
See github issue #3 for some more notes about that issue.