This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Fixes, clean up, and an attempt at Linux support. #26
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
536edbc
LINUX/CMakeLists.txt: Fix Linux #elif statement
c3r1c3 ea59b20
en-US.ini: Translations fix. We need to specify which version of VST …
c3r1c3 3f25cf6
LINUX/obs-vst.cpp: Had some trouble getting it to compile. This fixed…
c3r1c3 4c3ebdf
ALL/obs-vst.cpp: Optimized each platform to only find+filter+sort+sho…
c3r1c3 bf10df1
various: Formatting fixes.
c3r1c3 481611a
LINUX/VST GUI support: A disaster. Please try to figure it out.
c3r1c3 4f61448
LINUX/VST-Plugin.cpp: Trying to get Linux support into shape. Startin…
c3r1c3 32d87dd
VSTPlugin-win.cpp: Add Support for various other types of plugins
c3r1c3 67b7d8c
VSTPlugin-Linux.cpp: Add Support for various other types of plugins
c3r1c3 f635cfb
Fixed the Windows DLL Entry points.
c3r1c3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's copied from the windows code. Windows needs a wchar because the filesystem APIs for unicode accept a wchar. On linux and osx you should just be able to pass the string to the os_dlopen. So you can remove all this extra stuff here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for merging. Am working on it now. Will have a new PR for you soon-ish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also my next PR will include formatting fixes (if you haven't already done it) for everything.