Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requesthandler: Update scene item transform API #1203

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented Feb 19, 2024

Description

requires obsproject/obs-studio#10264

Motivation and Context

Prevents future deprecation warnings

How Has This Been Tested?

Tested OS(s): Windows 11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR into two PRs:

  1. Move from deprecated functions to non-deprecated functions.
  2. Add support for new cropToBounds feature.

@Lain-B Lain-B force-pushed the crop_to_bounds branch 3 times, most recently from b2b0863 to bb639f0 Compare February 21, 2024 03:16
@Lain-B Lain-B changed the title requesthandler: Add crop to bounds support requesthandler: Update obs_transform API Feb 21, 2024
Updates:
obs_sceneitem_get_info to obs_sceneitem_get_info2
obs_sceneitem_set_info to obs_sceneitem_set_info2

Ensures that we're using the latest versions of these functions in order
to prevent future deprecation
@Lain-B Lain-B changed the title requesthandler: Update obs_transform API requesthandler: Update scene item transform API Feb 21, 2024
@Lain-B
Copy link
Contributor

Lain-B commented Feb 21, 2024

@tt2468 I fixed the splitting issue with this PR and renamed it; just solves future deprecation warnings. Going to merge this one to get the beta out.

@Lain-B Lain-B merged commit c44c2c7 into obsproject:master Feb 21, 2024
1 check passed
@exeldro exeldro deleted the crop_to_bounds branch February 21, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants