Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Add from and to scene names to transition events #1229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

duncte123
Copy link

@duncte123 duncte123 commented Jun 5, 2024

Description

As stated in #983 the v5 transition events are lacking a severe amount of data rendering them pretty much useless without having your own state (that desyncs the moment you have two clients)

Motivation and Context

The missing from and to scenes on the transition events is what's keeping me on v4. When this PR is released I will be able to switch off v4 and use v5.
It would fix #983 but currently the duration is missing so it's not fixed completely.

How Has This Been Tested?

Tested OS(s):

  • Ubuntu 22.04
  • Windows 10 22H2 19045.4412

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

These scene names are missing to make these events useful for anything other than monitoring
@duncte123 duncte123 force-pushed the feat/transition-data branch from 2387dc2 to c21afa4 Compare August 8, 2024 07:24
@duncte123
Copy link
Author

Whoops, soft resetted too much

@inkfarer
Copy link

I'd be thrilled to have this merged, knowing what scene is being transitioned to as the scene transition starts is very useful for me.

@duncte123 - Should the transition events also contain the UUIDs of the scenes being transitioned from and to?

@duncte123
Copy link
Author

Should the transition events also contain the UUIDs of the scenes being transitioned from and to?

Personally I don't have any use case for this, if any of the maintainers want this functionality I'd be happy to add it next to the scene names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Hydrate some events with additional data in comparison to the v4 counterparts
2 participants