Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC: Downstream keyer #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add RFC: Downstream keyer #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions accepted/0011-downstream-keyer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
- Start Date: 2020-01-23
- RFC PR: #11
- Mantis Issue: https://obsproject.com/mantis/view.php?id=602

- Related PRs:
1. https://github.com/obsproject/obs-studio/pull/1321

# Summary

Add the ability for users to create global scenes thats are on top of every scene.

# Motivation

Users won't have to create meta scenes and copy them to every scene.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion:

# Motivation

1. Users won't have to create meta scenes and copy them to every scene.
2. The global scene won't affected by scenes transition effect.


# Detailed design

## User UX

- Have an extra dock for the DSK scene (same as the scenes dock)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, and it should be treated like a secondary scene list, probably with its own transitioning. Question is how to handling transitioning, especially considering people might want to use different transitions for DSKs.

- Have the dock on by default, so users easily know about it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this, I think this goes against the current design pattern where advanced features are hidden/separated by default.

- Users could switch between DSK channels with combo box in the dock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would prefer to just have a DSK 1 scene list, DSK 2 scene list or something like that. Probably even separate docks for them. I'm not sure how others would feel about that idea however. @dodgepong might have some strong opinions here.

- Alternatively, use hotkeys to change DSK channels, so we don't clog up the UI
- There would be an extra option in the combo box for disabling the DSK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, having a "None" option for the DSK which it would be set to by default or something would likely be necessary.

Copy link

@unknowndomain unknowndomain May 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is that the DSK is functionally a clone of the Scenes list so you can only show one at a time, where you'd reasonably expect to be able to toggle DSK 1, 2, 3 on and off like muting or unmuting audio sources.

Copy link

@summershrimp summershrimp Oct 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DSK should reuse the original scenes, may have separate transition effect. So we needn't make a whole new scene lists for them, we can just add a "Transit to Global Overlay" option to scenes' right-click menu. And add a "Global Overlay Transition Effect" selector below the original scenes' transition effect selector, or may just use current active transition effect. In this way, it's more like a traditional hardware switcher.
Using a new Scenes list for DSK is also acceptable.

- Call the DSK "Global Scenes" so users would more likely know what it is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's more of an advanced feature, I don't think we necessarily need to dumb down the name.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's a more advanced feature but when users realise this is the way to do channel bugs etc. I suspect it will get more use, and thats more likely if it's called global rather than DSK.

It might be interesting in future to add a notification when a user adds a source to multiple scenes (3+) the first time to show a dialog that tells them about global scenes and offers to enable it for them.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be called "(Active) Output Overlay Scene" or "(Active) Global Overlay Scene".


## Other

- PR only implemented single DSK channel
- In the PR, users could disable the DSK with hotkeys
- PR needs to be refactored to remove libobs usage

# Drawbacks

Users might not know what a DSK is.

# Alternatives

Add an existing scene to scenes.