-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parallel benchmark mergesort #336
base: main
Are you sure you want to change the base?
Conversation
…ctive dune files with corresponding runs in run_config.json
Compiler opam removed
Hi @Sudha247 please review this PR for errors and possible fix. Thanks |
I'm on my phone, I'll be able to give a better review when I'm back at my computer. But from what I see in the CI failure, it looks like the Common module is missing. It needs to be imported from the original repo. An easy way to do that would be copying the file to the directory you are currently working on. |
Hello @sudha after a series of build failures in PR #336 I see that "CCArray_slice module is used in mergesort.ml and common.ml which are inter-dependent. However I found out that "Array_slice" module has been removed as referenced here |
Thanks for the PR @ernestmusong! Good catch! It appears A quick way to test would be to use an older version of |
Hi @Sudha247 I've downgraded the version domainslib and containers as specified in the repo but still get this error when run: "The module AS is an alias for module CCArray_slice, which is missing |
Hello @Sudha247 after a deep comparison between CCArray and CCArray_slice as used in mergesort and qsort, there exist common methods such as get, set, and lenght as used in the benchmarks. However, qsort seems easier to fix because it contains just "CCArray_slice.full" that is not present in CCArray. Further research could probably find a replacement for CCArray_slice.full. to make this benchmark running. On the other hand, mergesort contains additional methods which have no equivalence in CCArray such as CCArray_slice.sub. Please I would love to add qsort instead of mergesort as soon as I get a replacement for CCArray_slice.full |
No description provided.