Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken result aggregation when SANDMARK_CUSTOM_NAME is not specified #374

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix broken result aggregation when SANDMARK_CUSTOM_NAME is not specified #374

wants to merge 4 commits into from

Conversation

punchagan
Copy link
Contributor

@punchagan punchagan commented Jul 18, 2022 •
edited
Loading

Closes #347

@punchagan punchagan requested a review from shakthimaan July 18, 2022 07:53
shakthimaan
shakthimaan reviewed Jul 25, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@punchagan punchagan force-pushed the 347-fix-run-all branch 2 times, most recently from cffc724 to 3ada19a Compare July 26, 2022 07:56
@punchagan
Copy link
Contributor Author

@shakthimaan I rebased this against the latest main and is merge-able now. Could you take another look?

@punchagan punchagan force-pushed the 347-fix-run-all branch 4 times, most recently from 2352eb1 to 6b22dd7 Compare December 14, 2022 13:35
@shakthimaan
Copy link
Contributor

The 5.1.0+trunk build is failing with:

 [ERROR] Package conflict!
  * Missing dependency:
No solution found, exiting
    - dev → runtime_events_tools → tracing → core >= v0.15 → base >= v0.15
    not available because the package is pinned to version v0.14.3
    ```

@punchagan
Copy link
Contributor Author

This is a new failure, and probably new builds on main will also start failing. I'll work on a fix.

@punchagan punchagan force-pushed the 347-fix-run-all branch 4 times, most recently from b701805 to f0b40bc Compare January 2, 2023 08:02
@punchagan
Obtain SANDMARK_CUSTOM_NAME from variant name and make it optional
3644d7c 
But, also allow overriding it using an environment variable, if required.

Also, cleanup on each run in CI to avoid having multiple bench files in the
`_results/` directory when we benchmarks are run with different variant names.
@punchagan
Rename SANDMARK_CUSTOM_NAME to VARIANT_NAME
e97dbdf 
Closes ocaml-bench#347
@punchagan
DBG: verbose
6a33f60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakthimaan shakthimaan shakthimaan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Results aggregation broken
2 participants
@punchagan @shakthimaan