WIP: Attempt to fix Cmi_format error in voodoo-do, by checking in prep that the magic numbers are ok #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabine
force-pushed
the
fix_cmi_format_error
branch
from
c8f32c2 to
01db246
Compare
|
The other way would be to catch it at source - ie, in prep. |
|
This patch is trying to catch it in prep. I think if there's a reliable way to catch it there, that would be preferable. |
sabine
changed the title
gpetiot
reviewed
Jul 14, 2023
sabine
force-pushed
the
fix_cmi_format_error
branch
from
01db246 to
35fdec9
Compare
sabine
force-pushed
the
fix_cmi_format_error
branch
from
58ec9ae to
e6d146f
Compare
gpetiot
reviewed
Jul 25, 2023
Co-authored-by: Guillaume Petiot <[email protected]>
sabine
force-pushed
the
fix_cmi_format_error
branch
from
9dda26c to
2f7b1f4
Compare
* Use read_cmt/cmi functions from compiler-libs Co-authored-by: Guillaume Petiot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a better way to check that we won't get a
Cmi_formaterror? I really don't understand everything that's going on here and if this is a useful check.The other possibility to fix the
Cmi_formaterror that's caused by copying files generated by the wrong OCaml compiler version would be to catch theCmi_formaterror in voodoo-do and discard it, if I understand it correctly.