Build voodoo cli tools in docker container. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes me slightly nervous, but only because voodoo-gen is still linking directly against odoc rather than executing it as a binary. If we can fix that then the voodoo cli tools are really just scripts that execute other tools, and I'm very happy to see them independent of the switch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress Dockerfile for building the voodoo tools.
These can then be used in
ocaml-docs-cias an artifact and we could avoid building them from source. Still working on the ocurrent plumbing to start using these.Note the use of a specific opam-repository git checkout effectively pins the universe of opam packages available.