Better hugepage alignment of stacks and heap #3384
Open
+20
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the memory mapping of the runtime in two ways (which I noticed after #3351):
caml_mem_map
does hugepage alignment these days, there is no longer a need for custom 2MB alignment infiber.c
. (In passing, also fix a couple of other issues: error handling logic was wrong, and there's no need to mprotect memory you're about to unmap)The result is that the OCaml parts of the memory map now have pleasant alignment. (Note the 8184 kB stack allocation, ending on a hugepage boundary. This means that the top of the stack will be hugepage-aligned).