Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horrible quadratic baggage #3411

Draft
wants to merge 3 commits into
base: aspsmith/with-kind-modalities
Choose a base branch
from

Conversation

glittershark
Copy link
Member

let's see how horrible this actually is

Per zqian's CR to this effect. note that this does not do any of the
simplification that this unlocks yet, that'll happen later
Now that the types for jkind axes and mode axes have been unified, we
can express the condition for "modality is const for axis" directly,
without resorting to a huge ugly pattern match on the axis and the
modality's atoms.
@glittershark glittershark force-pushed the aspsmith/horrible-quadratic-baggage branch from 24851ae to 0d7970f Compare December 29, 2024 17:30
@glittershark
Copy link
Member Author

at least insofar as the compiler test suite is a reasonable performance benchmark for the compiler, this is... not actually terrible?

before:

user=697.35s system=219.18s cpu=1161% total=1:18.89

after:

user=812.91s system=217.03s cpu=891% total=1:55.51

@glittershark glittershark force-pushed the aspsmith/horrible-quadratic-baggage branch from 0d7970f to e9af4c5 Compare December 29, 2024 17:51
@glittershark glittershark changed the base branch from aspsmith/untype-jkind to aspsmith/normalize-mode-axis-types December 29, 2024 17:51
Base automatically changed from aspsmith/normalize-mode-axis-types to aspsmith/with-kind-modalities January 6, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant