Add a new attribute for allowing any mode crossing #3424
+178
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the [@@unsafe_allow_any_kind_in_{impl,intf}] attributes with a new
[@@unsafe_allow_any_mode_crossing] attribute. This is different in that it:
1. Works on the type declaration, not the inclusion check, so is more powerful -
it can be used to illegally mode cross types defined in the same module, or
illegally mode cross non-abstract types in interfaces. The latter especially
is necessary to fully subsume -allow-illegal-crossing in stdlib
2. Only allows changing the modal bounds of a kind, not the layout - it's
unclear that anyone should ever want to unsafely change the layout of a kind;
I personally can't think of any sound reason to do so.
Some [past discussion][0] on the specific syntax for this attribute suggested
specifying the bounds directly on the attribute, rather than using the jkind
annotation, but I and others feel reasonably strongly that this way of doing
things is a better design for the sake of consistency.
[0]: #3385 (comment)
glittershark
force-pushed
the
aspsmith/better-adjust-kind-attribute
branch
from
a6c01ea to
05de766
Compare
We might have those reasons when we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
[@@unsafe_allow_any_kind_in_{impl,intf}]attributes with a new[@@unsafe_allow_any_mode_crossing]attribute. This is different in that it:Some past discussion on the specific syntax for this attribute suggested specifying the bounds directly on the attribute, rather than using the jkind annotation, but I and others (@tdelvecchio-jsc, @ccasin) feel that this approach is a better design for the sake of consistency and ease-of-use.