add test for multiple signature items #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
force-pushed
the
ps/rr/add_test_for_multiple_signature_items
branch
2 times, most recently
from
8c96606 to
ba9aeaf
Compare
|
The test is failing on OCaml 4.08 only. It looks like lines reporting is different on that version 🤷♂️ - File "test.ml", lines 1-3, characters 0-16:
+ File "test.ml", line 1, characters 0-40: |
|
I think this is an issue in version 4.08 that got fixed in 4.09 ocaml/ocaml#8541 |
tatchi
force-pushed
the
ps/rr/add_test_for_multiple_signature_items
branch
2 times, most recently
from
472e9ef to
ec0a4af
Compare
tatchi
commented
Feb 8, 2023
| OCaml 4.08 reports different numbers. | ||
| It's been fixed for later versions in https://github.com/ocaml/ocaml/pull/8541 | ||
| $ dune build 2>&1 | sed -r 's/(line(s?)|character(s?)) [0-9]+(-[0-9]+)?/\1 %NUMBER%/g' | ||
| File "test.ml", lines %NUMBER%, characters %NUMBER%: |
There was a problem hiding this comment.
I made the line and character numbers agnostic to fix the difference with OCaml 4.08
tatchi
force-pushed
the
ps/rr/add_test_for_multiple_signature_items
branch
from
ec0a4af to
3c01f68
Compare
<!-- ps-id: 597fd8ce-d920-40ad-b1e3-2bad11222b23 -->
tatchi
force-pushed
the
ps/rr/add_test_for_multiple_signature_items
branch
from
3c01f68 to
3b3b3f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.