Add AST section to examples #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobslisboa
force-pushed
the
examples/ast
branch
from
3c7b85f to
e5e4945
Compare
pedrobslisboa
requested review from
ceastlund,
NathanReb,
panglesd,
patricoferris and
pitag-ha
as code owners
pedrobslisboa
force-pushed
the
examples/ast
branch
5 times, most recently
from
6a2f1e9 to
6ad21fe
Compare
pedrobslisboa
force-pushed
the
examples/ast
branch
from
6ad21fe to
160f335
Compare
pedrobslisboa
commented
Dec 23, 2024
Makefile
Outdated
There was a problem hiding this comment.
@NathanReb I've made some improvements on Makefile, can you check out if it makes sense?
The main feature is to add doc-dev, but I also added the help command
|
@patricoferris Tagging you for the review as you reacted to this PR |
pedrobslisboa
commented
Dec 23, 2024
doc/dune
Outdated
Comment on lines
10
to
12
| (system "mkdir -p %{project_root}/_doc/_html/ppxlib/assets/images") | ||
| (system "cp -R ./images/ %{project_root}/_doc/_html/ppxlib/assets/images/")))) |
There was a problem hiding this comment.
Btw, I didn't know any other way to get assets on odoc. Do you guys happen to know?
pedrobslisboa
force-pushed
the
examples/ast
branch
4 times, most recently
from
7020fc9 to
7bf1887
Compare
Signed-off-by: Pedro B S Lisboa <[email protected]>
pedrobslisboa
force-pushed
the
examples/ast
branch
from
7bf1887 to
2aeef20
Compare
|
@pedrobslisboa just pushed a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
41 files where: 20 are pngs and 8 are old examples files deleted. So don't be scared
Description
This is the first part of adding the ppx-by-example to ppxlib
I will divide it into PR so we can review it better, focusing on the explanation and typos without having tons of files to review. It is really necessary that this section is easy to understand and is aligned with ppxlib.
@NathanReb Can you create a
ppx-by-examplebase branch? So I can point this one to it, and after all merges (Other sections) on this branch, we move with the entireppx-by-examplebranch to main?AST
This PR adds the AST sections AST / Building ASTs / Destructing ASTs
How to test it (It's important to check it not only by code but also as styles)