Skip to content

Commit

Permalink
Encourage adding email in author & maintainer info (#10848)
Browse files Browse the repository at this point in the history
For packages submitted to the opam-repository, it would help to have the
email addresses of the maintainers. See ocaml/infrastructure#152. This
commit subtly encourages package authors/maintainers to do so.

Signed-off-by: Puneeth Chaganti <[email protected]>
  • Loading branch information
punchagan authored Aug 28, 2024
1 parent 28fe966 commit beea68f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/dune_lang/package_info.ml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ let example =
{ source =
Some (Host (Source_kind.Host.Github { user = "username"; repo = "reponame" }))
; license = Some [ "LICENSE" ]
; authors = Some [ "Author Name" ]
; maintainers = Some [ "Maintainer Name" ]
; authors = Some [ "Author Name <[email protected]>" ]
; maintainers = Some [ "Maintainer Name <[email protected]>" ]
; documentation =
Some "https://url/to/documentation"
(* homepage and bug_reports are inferred from the source *)
Expand Down
16 changes: 8 additions & 8 deletions test/blackbox-tests/test-cases/dune-init.t/run.t
Original file line number Diff line number Diff line change
Expand Up @@ -345,9 +345,9 @@ In particular, the `dune-project` file has the expected content:
(source
(github username/reponame))

(authors "Author Name")
(authors "Author Name <author@example.com>")

(maintainers "Maintainer Name")
(maintainers "Maintainer Name <maintainer@example.com>")

(license LICENSE)

Expand Down Expand Up @@ -376,8 +376,8 @@ And the opam file will be generated as expected
opam-version: "2.0"
synopsis: "A short synopsis"
description: "A longer description"
maintainer: ["Maintainer Name"]
authors: ["Author Name"]
maintainer: ["Maintainer Name <maintainer@example.com>"]
authors: ["Author Name <author@example.com>"]
license: "LICENSE"
tags: ["topics" "to describe" "your" "project"]
homepage: "https://github.com/username/reponame"
Expand Down Expand Up @@ -455,9 +455,9 @@ In particular, the `dune-project` file has the expected content:
(source
(github username/reponame))

(authors "Author Name")
(authors "Author Name <author@example.com>")

(maintainers "Maintainer Name")
(maintainers "Maintainer Name <maintainer@example.com>")

(license LICENSE)

Expand Down Expand Up @@ -486,8 +486,8 @@ And the opam file will be generated as expected
opam-version: "2.0"
synopsis: "A short synopsis"
description: "A longer description"
maintainer: ["Maintainer Name"]
authors: ["Author Name"]
maintainer: ["Maintainer Name <maintainer@example.com>"]
authors: ["Author Name <author@example.com>"]
license: "LICENSE"
tags: ["topics" "to describe" "your" "project"]
homepage: "https://github.com/username/reponame"
Expand Down

0 comments on commit beea68f

Please sign in to comment.