-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Move glob syntax to dune-glob (#7988) #10163
base: main
Are you sure you want to change the base?
Conversation
Thanks.
|
If it's rendered properly IMHO we could go with that. If I'm not mistaken, at some point it could end up as broken link. |
448b684
to
9dccc80
Compare
dune-project
Outdated
@@ -131,6 +131,7 @@ execution of the action. | |||
(stdune (= :version)) | |||
dyn | |||
ordering | |||
(odoc (>= 2.3.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think It is a good idea to have dune-glob
and dune
packages, exclusive regarding odoc
version. I don't know what is behind constraining odoc
to 2.0.1 in dune
package.
Doesn't this add odoc as a build dependency? Is that really what is needed? Shouldn't it still be |
9dccc80
to
d79aa82
Compare
Indeed it should be |
d79aa82
to
c6d055d
Compare
if it requires ETA: a list of failing packages is here: https://staging.docs.ci.ocamllabs.io/package Tezos packages failing is normal. I restarted all failed jobs. |
Thanks @sabine ! I subscribed to the PR and will hold this one until it's merged. |
Signed-off-by: Alpha DIALLO <[email protected]>
c6d055d
to
4722c9f
Compare
Thanks @sabine for the merge of ocaml-doc/voodoo#128. You could start the review @emillon. |
That the pull request on voodoo has been merged does not mean that the deployment is successful. The voodoo patch has only been tested on all the newest versions of all the packages. It's okay to go ahead with reviewing this, but I would ask you to wait with a merge until after we know that the deployment is successful. For reference, the previous voodoo version succeeded to build documentation for 22939 packages and failed to build the documentation of 808 packages. The documentation pipeline at https://docs.ci.ocaml.org will start in roughly an hour to build all package documentation with the new voodoo version. |
Fixes #7988