Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add an action to build binaries #10479

Merged
merged 1 commit into from
May 3, 2024
Merged

ci: add an action to build binaries #10479

merged 1 commit into from
May 3, 2024

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented May 3, 2024

This adds a manual workflow to get binaries for:

  • linux (intel)
  • mac (intel)
  • mac (arm)

In addition, a combined zip is available.

@emillon emillon force-pushed the action-binaries branch from 3b70abf to 8ba4e91 Compare May 3, 2024 09:48
@emillon emillon marked this pull request as ready for review May 3, 2024 09:51
@emillon emillon requested a review from Leonidas-from-XIV May 3, 2024 09:51
Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that nix can be used to deal with both OSes!

.github/workflows/binaries.yml Outdated Show resolved Hide resolved
.github/workflows/binaries.yml Outdated Show resolved Hide resolved
This adds a manual workflow to get binaries for:

- linux (intel)
- mac (intel)
- mac (arm)

In addition, a combined zip is available.

Signed-off-by: Etienne Millon <[email protected]>
@emillon emillon force-pushed the action-binaries branch from 7b380de to 55f3285 Compare May 3, 2024 14:48
@emillon emillon requested a review from Leonidas-from-XIV May 3, 2024 14:48
@emillon emillon merged commit 077d492 into main May 3, 2024
27 checks passed
@emillon emillon deleted the action-binaries branch May 3, 2024 15:47
@anmonteiro
Copy link
Collaborator

I wonder if it'd be interesting to build a statically linked binary too, e.g. dune-musl64 on x86_64 linux.

I wonder if that'd allow distributing dune as a standalone binary, which could be especially useful for dune 4 and dune-pkg.

@emillon
Copy link
Collaborator Author

emillon commented May 6, 2024

I wonder if that'd allow distributing dune as a standalone binary, which could be especially useful for dune 4 and dune-pkg.

I should have mentioned that, but yes that's the motivation behind that workflow: this way we can distribute binaries so that people can easily test that without installing anything else.

I wonder if it'd be interesting to build a statically linked binary too, e.g. dune-musl64 on x86_64 linux.

Sounds like a good idea, is there a "standard" way to do this with nix?

@anmonteiro
Copy link
Collaborator

Sounds like a good idea, is there a "standard" way to do this with nix?

It should be really easy with my overlays to build pkgsCross.musl64.ocaml-ng.ocamlPackages_4_14.dune.

@emillon
Copy link
Collaborator Author

emillon commented May 6, 2024

done in #10485

anmonteiro pushed a commit to anmonteiro/dune that referenced this pull request Nov 17, 2024
This adds a manual workflow to get binaries for:

- linux (intel)
- mac (intel)
- mac (arm)

In addition, a combined zip is available.

Signed-off-by: Etienne Millon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants