Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass -w -53 in wrapped_compat modules #10699

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: pass -w -53 in wrapped_compat modules #10699

merged 2 commits into from
Jul 8, 2024

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Jul 5, 2024

On OCaml 5.2, this feature triggers warning 53, which is justified.

Quoting @nojb:

Dune first builds bar.cmi and bar.cmo from bar.ml-gen and this part
works well (bar.ml-gen contains a top-level attribute but no .cmi).
However, when it is the turn of the native-code compiler, bar.cmi
already exists (and contains the expected deprecation attribute), so the
top-level attribute in Bar.ml-gen is correctly ignored by the compiler,
hence the warning.

Fixes #10689

On OCaml 5.2, this feature triggers warning 53, which is justified.

Quoting @nojb:

> Dune first builds bar.cmi and bar.cmo from bar.ml-gen and this part
> works well (bar.ml-gen contains a top-level attribute but no .cmi).
> However, when it is the turn of the native-code compiler, bar.cmi
> already exists (and contains the expected deprecation attribute), so the
> top-level attribute in Bar.ml-gen is correctly ignored by the compiler,
> hence the warning.

Fixes #10689

Signed-off-by: Etienne Millon <[email protected]>
@emillon emillon requested a review from nojb July 5, 2024 12:31
Copy link
Collaborator

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if it works :))

@emillon emillon merged commit 7c423c5 into main Jul 8, 2024
25 of 28 checks passed
@emillon emillon deleted the fix-10689 branch July 8, 2024 08:53
anmonteiro pushed a commit to anmonteiro/dune that referenced this pull request Nov 17, 2024
On OCaml 5.2, this feature triggers warning 53, which is justified.

Quoting @nojb:

> Dune first builds bar.cmi and bar.cmo from bar.ml-gen and this part
> works well (bar.ml-gen contains a top-level attribute but no .cmi).
> However, when it is the turn of the native-code compiler, bar.cmi
> already exists (and contains the expected deprecation attribute), so the
> top-level attribute in Bar.ml-gen is correctly ignored by the compiler,
> hence the warning.

Fixes ocaml#10689

Signed-off-by: Etienne Millon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocaml 5.2: warning 53 with (wrapped (transition))
2 participants