Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGES #1008

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Update CHANGES #1008

merged 6 commits into from
Sep 27, 2023

Conversation

jonludlam
Copy link
Member

No description provided.

Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small comments!

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Comment on lines +18 to +19
- odoc-parser remerged (@jonludlam, #973)
This includes table support (@gpetiot, @panglesd, ocaml-doc/odoc-parser#11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things related to tables should be moved to "Handle tables markup" above.

The odoc-parser remerge should be in the "Changed" section (here it's in "Added").

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added seemed more appropriate to me, since we've added a whole opam package.

jonludlam and others added 5 commits September 27, 2023 14:18
Co-authored-by: panglesd <[email protected]>
Co-authored-by: panglesd <[email protected]>
Co-authored-by: panglesd <[email protected]>
Co-authored-by: panglesd <[email protected]>
Co-authored-by: panglesd <[email protected]>
@jonludlam jonludlam merged commit b04251c into ocaml:master Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants