Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin of first child of odoc-content #1147

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

EmileTrotignon
Copy link
Collaborator

This fixes the gap in between the preamble and the content without changing other margins, or changing the structure of the HTML.

@EmileTrotignon
Copy link
Collaborator Author

This is a follow-up to PRs #1143 and #1146. It aims to fix issue #1111.

@panglesd
Copy link
Collaborator

There is still a gap between preamble and content:

image

This is due to that.

Even if smaller than before, this gap will be unexpected to most people who do not know there is a notion of preamble in odoc. Now that I understood that, I think it would be better not to remove the gap, but to make it understandable:

image

That being said, go with what you prefer.

@EmileTrotignon
Copy link
Collaborator Author

As far as I understand, the gap was there before we switched to grid, and its quite reasonable to have a gap here.
If I am mistaken and this PR still has a larger gap than odoc pre-grid layout, I am happy to tune it, otherwise I think we should merge.

@panglesd
Copy link
Collaborator

Indeed, this PR reverts the introduction of a larger gap from #999.

Feel free to merge.

@EmileTrotignon EmileTrotignon merged commit f3a7ca9 into ocaml:master Jun 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants