Improve driver experience #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
added
the
no changelog
|
I'm quite happy with the json argument. |
Julow
reviewed
Dec 13, 2024
src/driver/odoc_driver.ml
Outdated
| @@ -205,6 +211,7 @@ let run mode | |||
| else [] | |||
| in | |||
| Logs.debug (fun m -> m "XXXX Remaps length: %d" (List.length remaps)); | |||
| Format.eprintf "Starting the compilation process... \n%!"; | |||
There was a problem hiding this comment.
Shouldn't this be Logs.info ?
There was a problem hiding this comment.
Good point. However, shouldn't this be Logs.app?
Currently, the Info level is a bit too verbose. Eg:
odoc_driver.exe: [INFO] Unable to determine library of archive ocamlmiddleend: Ignoring.
odoc_driver.exe: [INFO] No files for module: Tophooks
odoc_driver.exe: [INFO] Unable to determine library of archive odoc_info: Ignoring.
odoc_driver.exe: [INFO] No files for module: Findlib
odoc_driver.exe: [INFO] No files for module: Findlib_config
odoc_driver.exe: [INFO] No files for module: Fl_args
odoc_driver.exe: [INFO] No files for module: Fl_lint
odoc_driver.exe: [INFO] No files for module: Fl_meta
odoc_driver.exe: [INFO] No files for module: Fl_metascanner
odoc_driver.exe: [INFO] No files for module: Fl_metatoken
odoc_driver.exe: [INFO] No files for module: Fl_package_base
odoc_driver.exe: [INFO] No files for module: Fl_split
odoc_driver.exe: [INFO] No files for module: Fl_topo
odoc_driver.exe: [INFO] No files for module: Ocaml_args
odoc_driver.exe: [INFO] No files for module: Fl_dynload
odoc_driver.exe: [INFO] No files for module: Topfind
will be displayed for any invokation of odoc_driver. I believe this should be fixed in another PR!
Julow
approved these changes
Dec 13, 2024
src/driver/odoc_driver.ml
Outdated
| @@ -205,6 +211,7 @@ let run mode | |||
| else [] | |||
| in | |||
| Logs.debug (fun m -> m "XXXX Remaps length: %d" (List.length remaps)); | |||
| Logs.app (fun m -> m "Starting the compilation process... \n%!"); | |||
There was a problem hiding this comment.
This newline and flush are probably unwanted. Logs does that again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--generate-json(@jonludlam let me know if you want me to revert this one, but it takes a bit of time when, for users, JSON output is not needed).