Source locations #981
Closed
Source locations #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should only be referred to by elements on that same source page. This is in contrast with the `SourceLocation identifier, which uses an anchor found using the Shapes API, and can refer across source pages. This commit introduces the constructor but it is currently unused.
This fixes the problem of having anchors that are too dependent on compiler internals by naming the anchor after the position in the source of the particular value.
It seems that module types don't have Uids in their shapes, but the uids exist in the `cmt_uid_to_loc` hashtbl. To preserve the links to these uids we therefore fall back to non-semantic anchors, e.g. `def-<n>` as opposed to `module-type-S.type-t`.
|
Closed in favour of #993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have stable anchors in rendered source.