Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bls12-381-legacy 0.4.4 #20215

Conversation

dannywillems
Copy link
Contributor

@dannywillems dannywillems commented Dec 13, 2021

This pull-request concerns:
-bls12-381-legacy.0.4.4: UNIX version of BLS12-381 primitives. Not implementating the virtual package bls12-381

See branch legacy
Simply removing ctypes-foreign dependency from 0.4.3.



🐫 Pull-request generated by opam-publish v2.1.0

@dannywillems dannywillems force-pushed the opam-publish-bls12-381-bls12-381-gen-bls12-381-js-bls12-381-js-gen-bls12-381-legacy-bls12-381-unix.0.4.4 branch from 819acbe to 32b0eb7 Compare December 13, 2021 08:50
@dannywillems dannywillems changed the title 6 packages from gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4.4-legacy/ocaml-bls12-381-0.4.4-legacy.tar.bz2 bls12-381-legacy 0.4.4 Dec 13, 2021
@dannywillems dannywillems force-pushed the opam-publish-bls12-381-bls12-381-gen-bls12-381-js-bls12-381-js-gen-bls12-381-legacy-bls12-381-unix.0.4.4 branch 2 times, most recently from 2d9c5b9 to 3c5f83f Compare December 13, 2021 12:45
]
build: ["dune" "build" "-j" jobs "-p" name "@install"]
run-test: ["dune" "runtest" "-p" name "-j" jobs]
dev-repo: "git+https://gitlab.com/dannywillems/ocaml-bls12-381.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dev-repo: "git+https://gitlab.com/dannywillems/ocaml-bls12-381.git"
available: arch != "arm32"
dev-repo: "git+https://gitlab.com/dannywillems/ocaml-bls12-381.git"

It seems that arm32 is not supported:


#=== ERROR while compiling bls12-381-legacy.0.4.4 =============================#
# context              2.1.1 | linux/arm32 | ocaml-base-compiler.4.13.1 | pinned(https://gitlab.com/dannywillems/ocaml-bls12-381/-/archive/0.4.4-legacy/ocaml-bls12-381-0.4.4-legacy.tar.bz2)
# path                 ~/.opam/4.13/.opam-switch/build/bls12-381-legacy.0.4.4
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p bls12-381-legacy -j 159
# exit-code            1
# env-file             ~/.opam/log/bls12-381-legacy-1869-26d336.env
# output-file          ~/.opam/log/bls12-381-legacy-1869-26d336.out
### output ###
#     ocamlopt test/legacy/test_fq12.exe (exit 2)
# (cd _build/default && /home/opam/.opam/4.13/bin/ocamlopt.opt -w -40 -g -o test/legacy/test_fq12.exe /home/opam/.opam/4.13/lib/zarith/zarith.cmxa -I /home/opam/.opam/4.13/lib/zarith /home/opam/.opam/4.13/lib/bigarray-compat/bigarray_compat.cmxa /home/opam/.opam/4.13/lib/integers/integers.cmxa -I /home/opam/.opam/4.13/lib/integers /home/opam/.opam/4.13/lib/ctypes/ctypes.cmxa -I /home/opam/.opam/4.13/lib/ctypes /home/opam/.opam/4.13/lib/ff-sig/ff_sig.cmxa /home/opam/.opam/4.13/lib/bls12-381-gen/bls12_381_gen.cmxa src/legacy/bls12_381_legacy.cmxa -I src/legacy /home/opam/.opam/4.13/lib/astring/astring.cmxa /home/opam/.opam/4.13/lib/cmdliner/cmdliner.cmxa /home/opam/.opam/4.13/lib/uutf/uutf.cmxa /home/opam/.opam/4.13/lib/alcotest/stdlib_ext/alcotest_stdlib_ext.cmxa /home/opam/.opam/4.13/lib/fmt/fmt.cmxa /home/opam/.opam/4.13/lib/fmt/fmt_cli.cmxa /home/opam/.opam/4.13/lib/re/re.cmxa /home/opam/.opam/4.13/lib/stdlib-shims/stdlib_shims.cmxa /home/opam/.opam/4.13/lib/alcotest/engine/alcotest_engine.cmxa /home/opam/.opam/4.13/lib/ocaml/unix.cmxa -I /home/opam/.opam/4.13/lib/ocaml /home/opam/.opam/4.13/lib/fmt/fmt_tty.cmxa /home/opam/.opam/4.13/lib/alcotest/alcotest.cmxa -I /home/opam/.opam/4.13/lib/alcotest /home/opam/.opam/4.13/lib/ff-pbt/ff_pbt.cmxa test/legacy/.test_fr.eobjs/native/dune__exe.cmx test/legacy/.test_fr.eobjs/native/dune__exe__Test_fq12.cmx)
# /usr/bin/ld: /usr/lib/gcc/arm-linux-gnueabihf/10/libgcc.a(_arm_addsubdf3.o): in function `__floatundidf':
# (.text+0x30c): multiple definition of `__aeabi_ul2d'; /home/opam/.opam/4.13/lib/tezos-rust-libs/librustc_bls12_381.a(compiler_builtins-441c17dbb4fcc13c.compiler_builtins.80nri95o-cgu.100.rcgu.o):/usr/src/rustc-1.48.0/vendor/compiler_builtins/src/macros.rs:225: first defined here
# collect2: error: ld returned 1 exit status
# File "caml_startup", line 1:
# Error: Error during linking (exit code 1)
#     ocamlopt test/legacy/test_fr.exe (exit 2)
# (cd _build/default && /home/opam/.opam/4.13/bin/ocamlopt.opt -w -40 -g -o test/legacy/test_fr.exe /home/opam/.opam/4.13/lib/zarith/zarith.cmxa -I /home/opam/.opam/4.13/lib/zarith /home/opam/.opam/4.13/lib/bigarray-compat/bigarray_compat.cmxa /home/opam/.opam/4.13/lib/integers/integers.cmxa -I /home/opam/.opam/4.13/lib/integers /home/opam/.opam/4.13/lib/ctypes/ctypes.cmxa -I /home/opam/.opam/4.13/lib/ctypes /home/opam/.opam/4.13/lib/ff-sig/ff_sig.cmxa /home/opam/.opam/4.13/lib/bls12-381-gen/bls12_381_gen.cmxa src/legacy/bls12_381_legacy.cmxa -I src/legacy /home/opam/.opam/4.13/lib/astring/astring.cmxa /home/opam/.opam/4.13/lib/cmdliner/cmdliner.cmxa /home/opam/.opam/4.13/lib/uutf/uutf.cmxa /home/opam/.opam/4.13/lib/alcotest/stdlib_ext/alcotest_stdlib_ext.cmxa /home/opam/.opam/4.13/lib/fmt/fmt.cmxa /home/opam/.opam/4.13/lib/fmt/fmt_cli.cmxa /home/opam/.opam/4.13/lib/re/re.cmxa /home/opam/.opam/4.13/lib/stdlib-shims/stdlib_shims.cmxa /home/opam/.opam/4.13/lib/alcotest/engine/alcotest_engine.cmxa /home/opam/.opam/4.13/lib/ocaml/unix.cmxa -I /home/opam/.opam/4.13/lib/ocaml /home/opam/.opam/4.13/lib/fmt/fmt_tty.cmxa /home/opam/.opam/4.13/lib/alcotest/alcotest.cmxa -I /home/opam/.opam/4.13/lib/alcotest /home/opam/.opam/4.13/lib/ff-pbt/ff_pbt.cmxa test/legacy/.test_fr.eobjs/native/dune__exe.cmx test/legacy/.test_fr.eobjs/native/dune__exe__Test_fr.cmx)
# /usr/bin/ld: /usr/lib/gcc/arm-linux-gnueabihf/10/libgcc.a(_arm_addsubdf3.o): in function `__floatundidf':
# (.text+0x30c): multiple definition of `__aeabi_ul2d'; /home/opam/.opam/4.13/lib/tezos-rust-libs/librustc_bls12_381.a(compiler_builtins-441c17dbb4fcc13c.compiler_builtins.80nri95o-cgu.100.rcgu.o):/usr/src/rustc-1.48.0/vendor/compiler_builtins/src/macros.rs:225: first defined here
# collect2: error: ld returned 1 exit status
# File "caml_startup", line 1:
# Error: Error during linking (exit code 1)
#     ocamlopt test/legacy/test_g1.exe (exit 2)
# (cd _build/default && /home/opam/.opam/4.13/bin/ocamlopt.opt -w -40 -g -o test/legacy/test_g1.exe /home/opam/.opam/4.13/lib/zarith/zarith.cmxa -I /home/opam/.opam/4.13/lib/zarith /home/opam/.opam/4.13/lib/bigarray-compat/bigarray_compat.cmxa /home/opam/.opam/4.13/lib/integers/integers.cmxa -I /home/opam/.opam/4.13/lib/integers /home/opam/.opam/4.13/lib/ctypes/ctypes.cmxa -I /home/opam/.opam/4.13/lib/ctypes /home/opam/.opam/4.13/lib/ff-sig/ff_sig.cmxa /home/opam/.opam/4.13/lib/bls12-381-gen/bls12_381_gen.cmxa src/legacy/bls12_381_legacy.cmxa -I src/legacy /home/opam/.opam/4.13/lib/astring/astring.cmxa /home/opam/.opam/4.13/lib/cmdliner/cmdliner.cmxa /home/opam/.opam/4.13/lib/uutf/uutf.cmxa /home/opam/.opam/4.13/lib/alcotest/stdlib_ext/alcotest_stdlib_ext.cmxa /home/opam/.opam/4.13/lib/fmt/fmt.cmxa /home/opam/.opam/4.13/lib/fmt/fmt_cli.cmxa /home/opam/.opam/4.13/lib/re/re.cmxa /home/opam/.opam/4.13/lib/stdlib-shims/stdlib_shims.cmxa /home/opam/.opam/4.13/lib/alcotest/engine/alcotest_engine.cmxa /home/opam/.opam/4.13/lib/ocaml/unix.cmxa -I /home/opam/.opam/4.13/lib/ocaml /home/opam/.opam/4.13/lib/fmt/fmt_tty.cmxa /home/opam/.opam/4.13/lib/alcotest/alcotest.cmxa -I /home/opam/.opam/4.13/lib/alcotest /home/opam/.opam/4.13/lib/ff-pbt/ff_pbt.cmxa test/legacy/.test_fr.eobjs/native/dune__exe.cmx test/legacy/.test_fr.eobjs/native/dune__exe__Test_ec_make.cmx test/legacy/.test_fr.eobjs/native/dune__exe__Test_g1.cmx)
# /usr/bin/ld: /usr/lib/gcc/arm-linux-gnueabihf/10/libgcc.a(_arm_addsubdf3.o): in function `__floatundidf':
# (.text+0x30c): multiple definition of `__aeabi_ul2d'; /home/opam/.opam/4.13/lib/tezos-rust-libs/librustc_bls12_381.a(compiler_builtins-441c17dbb4fcc13c.compiler_builtins.80nri95o-cgu.100.rcgu.o):/usr/src/rustc-1.48.0/vendor/compiler_builtins/src/macros.rs:225: first defined here
# collect2: error: ld returned 1 exit status
# File "caml_startup", line 1:
# Error: Error during linking (exit code 1)
#     ocamlopt test/legacy/test_g2.exe (exit 2)
# (cd _build/default && /home/opam/.opam/4.13/bin/ocamlopt.opt -w -40 -g -o test/legacy/test_g2.exe /home/opam/.opam/4.13/lib/zarith/zarith.cmxa -I /home/opam/.opam/4.13/lib/zarith /home/opam/.opam/4.13/lib/bigarray-compat/bigarray_compat.cmxa /home/opam/.opam/4.13/lib/integers/integers.cmxa -I /home/opam/.opam/4.13/lib/integers /home/opam/.opam/4.13/lib/ctypes/ctypes.cmxa -I /home/opam/.opam/4.13/lib/ctypes /home/opam/.opam/4.13/lib/ff-sig/ff_sig.cmxa /home/opam/.opam/4.13/lib/bls12-381-gen/bls12_381_gen.cmxa src/legacy/bls12_381_legacy.cmxa -I src/legacy /home/opam/.opam/4.13/lib/astring/astring.cmxa /home/opam/.opam/4.13/lib/cmdliner/cmdliner.cmxa /home/opam/.opam/4.13/lib/uutf/uutf.cmxa /home/opam/.opam/4.13/lib/alcotest/stdlib_ext/alcotest_stdlib_ext.cmxa /home/opam/.opam/4.13/lib/fmt/fmt.cmxa /home/opam/.opam/4.13/lib/fmt/fmt_cli.cmxa /home/opam/.opam/4.13/lib/re/re.cmxa /home/opam/.opam/4.13/lib/stdlib-shims/stdlib_shims.cmxa /home/opam/.opam/4.13/lib/alcotest/engine/alcotest_engine.cmxa /home/opam/.opam/4.13/lib/ocaml/unix.cmxa -I /home/opam/.opam/4.13/lib/ocaml /home/opam/.opam/4.13/lib/fmt/fmt_tty.cmxa /home/opam/.opam/4.13/lib/alcotest/alcotest.cmxa -I /home/opam/.opam/4.13/lib/alcotest /home/opam/.opam/4.13/lib/ff-pbt/ff_pbt.cmxa test/legacy/.test_fr.eobjs/native/dune__exe.cmx test/legacy/.test_fr.eobjs/native/dune__exe__Test_ec_make.cmx test/legacy/.test_fr.eobjs/native/dune__exe__Test_g2.cmx)
# /usr/bin/ld: /usr/lib/gcc/arm-linux-gnueabihf/10/libgcc.a(_arm_addsubdf3.o): in function `__floatundidf':
# (.text+0x30c): multiple definition of `__aeabi_ul2d'; /home/opam/.opam/4.13/lib/tezos-rust-libs/librustc_bls12_381.a(compiler_builtins-441c17dbb4fcc13c.compiler_builtins.80nri95o-cgu.100.rcgu.o):/usr/src/rustc-1.48.0/vendor/compiler_builtins/src/macros.rs:225: first defined here
# collect2: error: ld returned 1 exit status
# File "caml_startup", line 1:
# Error: Error during linking (exit code 1)
#     ocamlopt test/legacy/test_pairing.exe (exit 2)
# (cd _build/default && /home/opam/.opam/4.13/bin/ocamlopt.opt -w -40 -g -o test/legacy/test_pairing.exe /home/opam/.opam/4.13/lib/zarith/zarith.cmxa -I /home/opam/.opam/4.13/lib/zarith /home/opam/.opam/4.13/lib/bigarray-compat/bigarray_compat.cmxa /home/opam/.opam/4.13/lib/integers/integers.cmxa -I /home/opam/.opam/4.13/lib/integers /home/opam/.opam/4.13/lib/ctypes/ctypes.cmxa -I /home/opam/.opam/4.13/lib/ctypes /home/opam/.opam/4.13/lib/ff-sig/ff_sig.cmxa /home/opam/.opam/4.13/lib/bls12-381-gen/bls12_381_gen.cmxa src/legacy/bls12_381_legacy.cmxa -I src/legacy /home/opam/.opam/4.13/lib/astring/astring.cmxa /home/opam/.opam/4.13/lib/cmdliner/cmdliner.cmxa /home/opam/.opam/4.13/lib/uutf/uutf.cmxa /home/opam/.opam/4.13/lib/alcotest/stdlib_ext/alcotest_stdlib_ext.cmxa /home/opam/.opam/4.13/lib/fmt/fmt.cmxa /home/opam/.opam/4.13/lib/fmt/fmt_cli.cmxa /home/opam/.opam/4.13/lib/re/re.cmxa /home/opam/.opam/4.13/lib/stdlib-shims/stdlib_shims.cmxa /home/opam/.opam/4.13/lib/alcotest/engine/alcotest_engine.cmxa /home/opam/.opam/4.13/lib/ocaml/unix.cmxa -I /home/opam/.opam/4.13/lib/ocaml /home/opam/.opam/4.13/lib/fmt/fmt_tty.cmxa /home/opam/.opam/4.13/lib/alcotest/alcotest.cmxa -I /home/opam/.opam/4.13/lib/alcotest /home/opam/.opam/4.13/lib/ff-pbt/ff_pbt.cmxa test/legacy/.test_fr.eobjs/native/dune__exe.cmx test/legacy/.test_fr.eobjs/native/dune__exe__Test_pairing.cmx)
# /usr/bin/ld: /usr/lib/gcc/arm-linux-gnueabihf/10/libgcc.a(_arm_addsubdf3.o): in function `__floatundidf':
# (.text+0x30c): multiple definition of `__aeabi_ul2d'; /home/opam/.opam/4.13/lib/tezos-rust-libs/librustc_bls12_381.a(compiler_builtins-441c17dbb4fcc13c.compiler_builtins.80nri95o-cgu.100.rcgu.o):/usr/src/rustc-1.48.0/vendor/compiler_builtins/src/macros.rs:225: first defined here
# collect2: error: ld returned 1 exit status
# File "caml_startup", line 1:
# Error: Error during linking (exit code 1)

Is that expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably related to rust-lang/compiler-builtins#353

Copy link
Member

@mseri mseri Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhugo Do you reckon that we shuold let it fail without restriction since this could be fixed at rust level at some point? I would be fine with this tbh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to me.

@mseri mseri merged commit 231a629 into ocaml:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants