-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] dns (13 packages) (9.1.0) #26773
Conversation
CHANGES: * Dns.Dnskey: provide to_string and name_key_to_string (@hannesm, @dinosaure, mirage/ocaml-dns#356 - fixes mirage/ocaml-dns#355) * BREAKING: Dns.Dnskey remove pp_name_key (unused, irritating, mirage/ocaml-dns#356) * BREAKING Dns_certify_mirage.retrieve_certificate use separate dns_key_name and dns_key arguments, avoid string decoding in that function (mirage/ocaml-dns#356)
your linting and our spam protection aren't in line. but I won't change that. There's as well multiple email addresses in the authors field. |
The CI failures are unrelated. Something I don't quite understand (and this can't be a regression in dns 9.1.0 -- it must've been around for 9.0.0 as well):
/cc @zshipko @samoht @art-w -- I'm not sure where in the irmin-client the rng is used, and library should be responsible to initialize it? any hints are welcome. I also wouldn't know what conflict / upper bound should be put into irmin-client -- any hints or ideas of people who care about irmin-client are welcome. |
added a constraint for irmin-client as indicated by @clecat in mirage/irmin#2348 |
CI looks fine to merge -- the irmin-client failures, I'm sorry about them, but this is not the PR to fix them. |
Thanks. I am curious to understand in what sense you mean about irmin? It seesm that tests are failing to run or run forever, do you think it is related to this release in some way? |
Thanks for merging @mseri. Sorry that my comment was not understandable. What I meant: dns 9.1.0 didn't change (in perspective to 9.0.0) anything related to the RNG - that's why I was surprised by the error. Furthermore, dns requires mirage-crypto >= 1.0.0, whereas irmin-client now requires <= 0.11.3. So, any irmin-client failures have to be unrelated to this release. The changes in dns from 9.0.0 to 9.1.0 are very small, and nothing that is used by irmin-client as far as I can tell - it is mostly in dns-certify (and some functions in Dns.Dnskey). So, the irmin-client failures must have been there before (either when irmin-client was released - or due to a release of another dependency). Hope this makes it more clear. |
An opinionated Domain Name System (DNS) library
CHANGES:
Provide Dns.Dnskey.to_string and Dns.Dnskey.name_key_to_string mirage/ocaml-dns#356 - fixes
Dns.Dnskey.pp_name_key
andDns.Dnskey.name_key_of_string
are not isomorph mirage/ocaml-dns#355)and dns_key arguments, avoid string decoding in that function (Provide Dns.Dnskey.to_string and Dns.Dnskey.name_key_to_string mirage/ocaml-dns#356)