Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dns (13 packages) (9.1.0) #26773

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Oct 22, 2024

An opinionated Domain Name System (DNS) library

CHANGES:

CHANGES:

* Dns.Dnskey: provide to_string and name_key_to_string (@hannesm, @dinosaure,
  mirage/ocaml-dns#356 - fixes mirage/ocaml-dns#355)
* BREAKING: Dns.Dnskey remove pp_name_key (unused, irritating, mirage/ocaml-dns#356)
* BREAKING Dns_certify_mirage.retrieve_certificate use separate dns_key_name
  and dns_key arguments, avoid string decoding in that function (mirage/ocaml-dns#356)
@hannesm
Copy link
Member Author

hannesm commented Oct 22, 2024

your linting and our spam protection aren't in line. but I won't change that. There's as well multiple email addresses in the authors field.

@hannesm
Copy link
Member Author

hannesm commented Oct 22, 2024

The CI failures are unrelated. Something I don't quite understand (and this can't be a regression in dns 9.1.0 -- it must've been around for 9.0.0 as well):

#=== ERROR while compiling irmin-client.3.9.0 =================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/irmin-client.3.9.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p irmin-client
# exit-code            1
# env-file             ~/.opam/log/irmin-client-7-be04b3.env
# output-file          ~/.opam/log/irmin-client-7-be04b3.out
### output ###
# File "test/irmin-client/dune", line 2, characters 7-11:
# 2 |  (name test)
#            ^^^^
# (cd _build/default/test/irmin-client && ./test.exe)
# Fatal error: exception The default generator is not yet initialized. 
# To initialize the RNG with a default generator, and set up entropy collection and periodic reseeding as a background task, do the following:
#   If you are using MirageOS, use the random device in config.ml: `let main = Mirage.main "Unikernel.Main" (random @-> job)`, and `let () = register "my_unikernel" [main $ default_random]`. 
#   If you are using Lwt, execute `Mirage_crypto_rng_lwt.initialize (module Mirage_crypto_rng.Fortuna)` at startup. 
#   If you are using Async, execute `Mirage_crypto_rng_async.initialize (module Mirage_crypto_rng.Fortuna)` at startup. 
#   If you are using Eio, execute in one of the fibers `Mirage_crypto_rng_eio.run (module Fortuna) env` (`env` from `Eio_main.run`).
#    
#   Otherwise, there is no periodic reseeding. For an initial seed from getrandom(), execute `Mirage_crypto_rng_unix.initialize (module Mirage_crypto_rng.Fortuna)`. You can use `Mirage_crypto_rng.accumulate` and `Mirage_crypto_rng.reseed` to reseed the RNG manually.

/cc @zshipko @samoht @art-w -- I'm not sure where in the irmin-client the rng is used, and library should be responsible to initialize it? any hints are welcome. I also wouldn't know what conflict / upper bound should be put into irmin-client -- any hints or ideas of people who care about irmin-client are welcome.

@hannesm
Copy link
Member Author

hannesm commented Oct 22, 2024

added a constraint for irmin-client as indicated by @clecat in mirage/irmin#2348

@hannesm
Copy link
Member Author

hannesm commented Oct 22, 2024

CI looks fine to merge -- the irmin-client failures, I'm sorry about them, but this is not the PR to fix them.

@mseri
Copy link
Member

mseri commented Oct 23, 2024

Thanks.

I am curious to understand in what sense you mean about irmin? It seesm that tests are failing to run or run forever, do you think it is related to this release in some way?

@mseri mseri merged commit 87a4585 into ocaml:master Oct 23, 2024
0 of 2 checks passed
@hannesm hannesm deleted the release-dns-v9.1.0 branch October 23, 2024 13:20
@hannesm
Copy link
Member Author

hannesm commented Oct 23, 2024

Thanks for merging @mseri. Sorry that my comment was not understandable.

What I meant: dns 9.1.0 didn't change (in perspective to 9.0.0) anything related to the RNG - that's why I was surprised by the error. Furthermore, dns requires mirage-crypto >= 1.0.0, whereas irmin-client now requires <= 0.11.3. So, any irmin-client failures have to be unrelated to this release.

The changes in dns from 9.0.0 to 9.1.0 are very small, and nothing that is used by irmin-client as far as I can tell - it is mostly in dns-certify (and some functions in Dns.Dnskey).

So, the irmin-client failures must have been there before (either when irmin-client was released - or due to a release of another dependency).

Hope this makes it more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dns.Dnskey.pp_name_key and Dns.Dnskey.name_key_of_string are not isomorph
2 participants