Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix constraints of the form "with-test >= Y" to "with-test & >= Y" #27102

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Dec 13, 2024

fix constraints of the form "Y >= with-test" to ">= Y & with-test"

@hannesm
Copy link
Member Author

hannesm commented Dec 13, 2024

CI looks fine, I don't plan to fix the build of these packages -- mainly a community service to have nice and clean dependency conjunctions ;)

@hannesm

This comment was marked as outdated.

@hannesm
Copy link
Member Author

hannesm commented Dec 15, 2024

I removed the gobba 0.4.2 changes -- and expect the CI runs to be fine now, apart from the error(s) in #27112

@mseri
Copy link
Member

mseri commented Dec 16, 2024

Lint has passed. Thanks!

@mseri mseri merged commit 23aff87 into ocaml:master Dec 16, 2024
0 of 2 checks passed
@hannesm hannesm deleted the fix-with-test branch December 16, 2024 10:26
@hannesm
Copy link
Member Author

hannesm commented Dec 17, 2024

I'm sorry, but I think c46b46b should be reverted since it is likely an instance of ocurrent/opam-repo-ci#405 I'll open a followup PR.

@mseri
Copy link
Member

mseri commented Dec 17, 2024

Oh man, there have been a few of those commits lately 😰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants