add ObKVParams #179
Open
add ObKVParams #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenyunlong
reviewed
Aug 30, 2024
| idx += len; | ||
| } else { | ||
| len = HTABLE_FILTER_DUMMY_BYTES.length; | ||
| System.arraycopy(HTABLE_FILTER_DUMMY_BYTES, 0, bytes, idx, len); |
shenyunlong
reviewed
Aug 30, 2024
| @@ -466,4 +483,13 @@ public void setScanRangeColumns(String... scanRangeColumns) { | |||
| public void setScanRangeColumns(List<String> scanRangeColumns) { | |||
| this.scanRangeColumns = scanRangeColumns; | |||
| } | |||
|
|
|||
| public void setObKVParams(ObKVParams obKVParams) { | |||
There was a problem hiding this comment.
setObKVParams -> setHbaseParams
shenyunlong
reviewed
Aug 30, 2024
|
|
||
| private int getContentSize() { | ||
| return 4 + Serialization.getNeedBytes(caching) + Serialization.getNeedBytes(callTimeout) | ||
| + 1; |
shenyunlong
reviewed
Aug 30, 2024
|
|
||
| public class ObHBaseParams extends ObKVParamsBase { | ||
| int caching = -1; // 限制scan返回的行的数量 | ||
| int callTimeout = -1; // scannerLeasePeriodTimeout，代表客户端scan的单个rpc超时时间以及服务端的scan的超时时间的一部分 |
There was a problem hiding this comment.
the comment should in English
shenyunlong
reviewed
Aug 30, 2024
| byte[] bytes = new byte[1]; // 1 byte for 4 booleans | ||
|
|
||
| if (allowPartialResults) | ||
| bytes[0] |= 0x01; // 00000010 |
There was a problem hiding this comment.
define 0x01 as a static const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solution Description