-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore error check on custom params inputs #1989
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Code Climate has analyzed commit 8dda0f0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 20.2% (0.0% change). View more on Code Climate. |
I can confirm that the issue is fixed right now, I could add the parameters attached to the algorithm. Thank you @EnzoVezzaro! I'll approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I noticed this fix broke the custom provider validation (try to remove the default provider and add a new one and you'll see the app crash), you could probably just add |
Great catch 👍🏽 I created a PR to fix this. Your solution @LucaMilanese90 seems to work, thanks for the help. |
Changes proposed in this PR:
HOW TO TEST:
Publish:
Edit: