Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove graphql query for accessDetails as it is return by aquarius #1996

Conversation

EnzoVezzaro
Copy link
Contributor

Changes proposed in this PR:

  • removed subgraph query for accessDetails during init

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 1 resolved Nov 10, 2023 10:19am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dubai-challenge ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 10:19am

@EnzoVezzaro
Copy link
Contributor Author

@nickscavuzzo33 can you please check if you can find the algo you're looking for on this PR.

@bogdanfazakas can you please check if ti's all good, specially with the changes done to the accessDetails

@nickscavuzzo33
Copy link

nickscavuzzo33 commented Nov 9, 2023

Algo Found - @bogdanfazakas @mihaisc should be good to merge

src/components/Asset/AssetActions/Compute/index.tsx Outdated Show resolved Hide resolved
src/components/Asset/AssetActions/Compute/index.tsx Outdated Show resolved Hide resolved
src/components/Asset/AssetActions/Compute/index.tsx Outdated Show resolved Hide resolved
src/@context/Asset.tsx Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Nov 10, 2023

Code Climate has analyzed commit d0bff4c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2% (0.0% change).

View more on Code Climate.

@LoznianuAnamaria
Copy link
Contributor

@nickscavuzzo33 If you can validate these changes in production it would be great

@LoznianuAnamaria LoznianuAnamaria merged commit a2ce8e4 into main Nov 10, 2023
15 checks passed
@LoznianuAnamaria LoznianuAnamaria deleted the feature/issue-1994-remove-subgraph-query-algorithm-component- branch November 10, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove subgraph query from algorithm component
4 participants