Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default value false for preventsChatReports #55

Merged
merged 1 commit into from Jul 16, 2024
Merged

Make default value false for preventsChatReports #55

merged 1 commit into from Jul 16, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2024

Codecs are smart and therefore won't send default data. When the default value is set to true and actual value to true, codec assumes that the client has true value by default and won't send it, but will send false value if actual value is false. This changes default value to false, so codec will send only true values.

Fixes #53.

Copy link
Collaborator

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - glad it's a simple fix

@pop4959 pop4959 merged commit 88d857c into ocelotpotpie:main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send-prevents-chat-reports-to-client not working
1 participant